[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets prerequisites
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 14 Oct 2022 19:35:20 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lvyclAa417B571VbYbZTVvqoRQ47YJifB9NMzfX9DK8=; b=LxmeKlPNqc32q7TrCrQbbS8QD8p541M4mpNdz4ViyS8HkIKSTPUZYDLYsVB4K9jCBNVmLjjVztMqxf/uMNwo8ZKV3fIKbplJILtqilKt7i7sMTNBBvAbzprQa+ZtvNnuMGPDoLT6UYa+MaCOLPXKos+d8KIAr790uEDIRiN30u2tKOUszaadkuIHUEUj6GFfOnCmEKVGMqRwtNfXTLcxbtGPvPwDbtJd6PrFQxhzhPJ90BJZkJhirnDM20B/yDlFAbXICTlbx+oaGBjESVO2CPH9fBFgh5S+wkcvty77EjnqPOlLGAcY7sL/c0r1bQEQHgg8xscJkwhgyUMVGxVWKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWh4hsNodgBipeaD4puDzowQlDzIpx3iZ22wrlKoW5WXOv6mfGnt2WQV3G9oxLW5TnxdHm6bd8mpMr4KFMoy3K84mQZaYwlO3vZOofvwb+mcUih0vFOttMe60CLtdOKhwiv4mFJx+52HMZQBMk1iThym1XygrMbXUTc9swwjQctQZIk/TGAYIajCtbWYLO7UjUsF0MpkFT8HHDxDVXquR3u5lfSkVfzu9KiPP/eBOLzgtHAxGadf9aatzQ5woy+j0cLEYas89aTTUec9gNV61bVnkEFaRygJzWWDNjU6ieLstUlP6oGfwSL2MiwkQqN668E+RrcYTbXNfPyT8c/+Zw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Fri, 14 Oct 2022 19:35:48 +0000
- Ironport-data: A9a23:PDVjOqMlGK/uyGbvrR2ClsFynXyQoLVcMsEvi/4bfWQNrUoq1jFTz GIXDGnSOq6MMGCke4h1Po3g/B4Avp7SndQyQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr5GtE1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eIYkb3rdOPkh1x e1bAxs3Tjqfobq0z+fuIgVsrpxLwMjDGqo64ygl5xeJSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+BTM+/tfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2iL3376VwnijMG4UPLag1v9Qg2+w/GAoDAxMVl+YrsbhrlHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LRQo2 UWOhMjBHiF0vfueTnf1y1uPhTa7OCxQJ2lSYyYBFFIB+4O6/tB1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxlolDGJ5T+REMWTm0Ms=
- Ironport-hdrordr: A9a23:F7M+iKzVZcmTIqns0godKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY3wX69onYif2p90CqYm9dW0vHXa4OSiQA
- Thread-topic: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets prerequisites
On 13/10/2022 14:05, Anthony Perard wrote:
> No need for $(AUTOSRCS), GNU make can generate them as needed when
> trying to build them as needed when trying to build the object. Also,
> those two AUTOSRCS don't need to be a prerequisite of "all". As for
> the "clean" target, those two files are already removed via "_*.c".
>
> We don't need $(AUTOINCS) either:
> - As for both _libxl_savm_msgs*.h headers, we are adding more
> selective dependencies so the headers will still be generated as
> needed.
> - "clean" rule already delete the _*.h files, so AUTOINCS aren't needed
> there.
>
> "libxl_internal_json.h" doesn't seems to have ever existed, so the
> dependency is removed.
>
> Add few prerequisite for "libxl_internal.h" so all headers that it
> depends on should be generated. And have $(SAVE_HELPER_OBJS) depends
> on "libxl_internal.h".
>
> Rework objects prerequisites, to have them dependents on either
> "libxl.h" or "libxl_internal.h". "libxl.h" is not normally included
> directly in the source code as "libxl_internal.h" is used instead. But
> we are adding "libxl.h" as prerequisite of "libxl_internal.h", so
> generated headers will still be generated as needed.
>
> "testidl.c" doesn't depends on "libxl.h" but "testidl.o" does.
I'm afraid I don't follow here. How can this be true?
~Andrew
|
