[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] argo: Fixes to argo_dprintk()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 14 Oct 2022 16:18:02 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+JBZO2UZ1F3kgYUn6aOyopHji/OhRvLI4eE7O5gQrg=; b=C6PkphRHizheNpWIEhb3x4cO4pR+JEGcqE1UIDkQk+KbJiojrVi84xUtSnZpeHsz90piOOeroT58Hg66p0VoAI2KfQ/RWUQvihZBY5kob623V2GHmQZxmvW1+VK9LTnK3uVypflbBv/O1om3Q3FrflYg5/DSy4Je/9OB7+9hUYlmjPWQU9KlMv55baMmePRTTczqP3rxF+8pvd0TTnncc72PKnzQd34E7zmgHJ2IPhLcqDLHUEZRalHCLTxDoftSew4JTJpzem9eLKc8CR/Rm4Zvd4+uuNI5l3k3+PfoEpuiwfOvWiS9oIK6nfROLJWXYH1YqDj61iCo1kgfxgQXYg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mXPTAhxxRm7OytTH/jwND1CrIEj9hWRtfLLzjnUs7dbZOj48UNsde/J4fyND8JqrJUMqeGDAAxaVLbtyA8ar64aJH4OCbqKJsMXQ2v+AxlIn4IRPQL3bwmOTEx+PokRZxMC0d4G0inlKh1ZhkaUtm3EtugcTNVqPvwGqUeyYnlYz+Rh7cRy7J0X0cALqzaFv87LmEq5ubjdG2hhBbkqyW2GUH8HqneVLxdiG5BRaH+T7zFR/UU809O0ANpJaeJSnGegzvXozJMd+Ifn7JIx9++66OCCVKIA/M3GSrsBgOLTWSsOSyfcD+J+/1BB4mAWBCfbHud6OPoDjM4IyC2amfA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 14 Oct 2022 14:18:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.10.2022 16:02, Andrew Cooper wrote:
> Rewrite argo_dprintk() so printk() format typechecking can always be
> performed.  This also fixes the evaluation of parameters.  Emit the messages
> at XENLOG_DEBUG.

I guess I don't really understand the "fixes the evaluation of parameters"
aspect: What is it that works differently now compared to before? If
ARGO_DEBUG is 0, none of the arguments will be evaluated, just like was
the case already.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.