[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 0/2] Ocaml stub fixes
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Thu, 13 Oct 2022 08:09:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Lodtgi2+evD3WbDutl8AkkNdWOS/Z/26nDlSKdciN4=; b=kqHYzUeJ5BXZ18U1Lz0K3qZdB3B0rCjCloFuyuuycW36jzBqAxKxjk85IpGk/xgOLVL98+6T8ZgAVJUnGoJISgPekQt1i/JMfi42lUWQRwyZDd1SohjAUwHX7rCUNW+y3pWKZtIJEZuHVwdEZSQn1GKUIjQ4fKDpdsbOVP+8mJ1g0el4toiEWpLHaA1g/NQvsG6lDQm8oUwQsbtWwiQC09kx+k4qwyxZJx12a0uQjhE4BTzuyzWZl1vNnGzCZq26xE8aPkdEHpuO7WaB1P8E7r4Xl6ndyyWP4wOP1n9uEqUW9UchJ7oD7vXsU5T/zJeKMMpp7GBazqio+/Gemajerw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GMQY47y+lgVM1Xny3YVJqYV3saUbKTKoXT/E+2ptMGQx2GS7brhR8S2yLdn6B81XVQ42CgxkIY3xswdT8ph27P2TyJRqXeord4BGaqJ4KH1CUQrS8DRMSHPXY5R2y3gMBMSuB4f7/1g1hJdFlJM2WRy4giQJjk+G33GM7USRKeSDbn+QWfGT6ULJuy3Zk1BOMD4J4d5mcjHoWk8G5BMk0zgBLzJNt2f7DY3zAfp+j3vJW90C0QnjAd38JhrgdXBNnIWDzgOkN/vRCPsJmGwqFqzu+yMmtcLKCd06mysXWyydiWlVzIhKzsjfkArvrqa9Vh8ZWO+hJS22pFVRrezhig==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Thu, 13 Oct 2022 08:09:47 +0000
- Ironport-data: A9a23:z42X+6CimYCSMBVWkefolCu1gh7EJpYLuyv04LjilXXVbZgPvEW2GDUMXjFqUIKe1WXHDttQOy/UMBlt8FzYagv8p5BLFtttQSI+XzvexR355Il+lbzZkNAns2zVKXgEFEBi+gHxvlL2oxoe37FNuc7nW8h/49hb+8tlzoQTc59gBha5l5fG5SehLr0aIfWB+0u35NDp7VMd/a3s3G+vI6FCJ+g1IqGYxtVmg9MREeieu/14rT2+A2EHKRxFvepusQjH9NaGu+0Lc2y+PZPji6g73XM6zLh9vrf10dffRozvjDkCZQEMwtZbAwWN0mjfIv75x9iAveTgewybTzZ9axOdsUVjNCJve+4Q5EYCi6qaVeIA62icYkWXxbZEHHBk+XObcKjYosopRZe5Untf76F1Am9Uw97OE9mRheu2uCc0fIR5JyGUfQOmn/txmmoslnRfVEu4cFEVT5IGW3mFmuY36IlFDe3YSdxPtgzbXA3gmU4a4U7CHWKCDlvHgUGQ30FbuCjFxlC54xJfRhBghLnAZaeQ2qQeY7YIllMFpTBJIFcfOgIzZSy5t2VKTGZnu8SsEsZAcKTgPrlzieNMaW6l1bhHXhTnDWGo3C/mVhRfIP8PTtJjZGPmR736mBkSSrliXKaNUJo/hGgE5LvXcGN47TBYQGxOAY0jtRtXkHSFNoEj8Sf4PpwOVMSHVsosSfgN9jUa60DoqeOYewSizEmc7qoZu3cZuhhjGvxy48N2OrUkspFouW982YJzyhqReR3+Zl7CyuMEBffnow34mFKPqF1LQXAgygS0cwmYiqdTeC31GUhpjurJuOOacI3Dl8BnIl24PrOAAfb7joN/AqH72sztQ8qd8aUt/ADIex22pdAfR2dA4N3BE07PhCw/Fvqaw//LEuV4Ip0bzrz/v9lKLNXfSSzJLOc1MlggxEhzuu44T6psy9LoETIXVICnAVHY+IEFs816mNpADEKW5/3Lqzrn8sCcZnyJVwqxrC3mw7rj8mCPHizYQ3Irx91SBoakfOsqWkzs0cQaS2SbrMA8nT/4+ofnc5/idlSqRA4K0MZqowIsglYBIUnNCidVwv+QwF3az4YsSF4f17iKIFszvwPsuBsXNdqAZE2viqhCNb8edSiGh4AC+957kRUDU/QmSNl85EIRLFoebFDg+b5n0eFa8DypCPjqvsV6IXIIgqOdox+9o2dBPZKsPMY5jnZXlYRAIjH2Yv7zYJjctWzapuCvw4Q05t8Xn4ohPRBV3ISj4VZwn0A13NybKGeqpQHqFQcl1juxBifgYiUE+F9Q+0zIVnwLCNOYf91yDRNAyyMKRrpDtBSly6ydbLrSgqX1tULcJ0tLLCqLPvHGw/yW+f175LHfX3tN1VVX+PL+tCi9t48ZZ3nccKX7CWgvbTan6PAz6EC/2S6A1OXZ21JyAtFDrN5ftCt3oj6xrwGDs971MclVjhZaM/c3p23gNVTDS8Q6JFRT60G/5wlxgvRq6Dl5XHPbiPvoEnM/LZmL66MJ6apOJF4EQJzgEENuBilxrzI2ptlO/KiWBSj6tdIg2VSp6X7+4MSakJXQiCDtesrJ0FzAo0wjRP+htaoX0a+iJ9V1tQ5RxYJQ9PZT64p9BtSIhEyYQpcHNcG1Aa4GAGSNRofGXGwTKp1fkNr6XYKMPzHNlcPXzqJBx0ZuTMmz88oLpIYR2VB727yMcFWZoWrPQN4aobyBVxm+CWowwuMuwKk+cyjNajOMYLwPqqaP4gS+AkvdI/j1z586VYX6yHUYdJhrW9/IokTVNUVeZNvtzLpCym1RfpYRPVvK/9kVVAYBgG32guVuKwyRtGaRZaGCCLd+2JSw6T8YGUR91FEb+XR9IaIXkrm53EobaGYGq+mjrfLtIk1G60IyyKETZKxWANX/qF2jDG1bdOpA3OA+uMkcgb3MU3Ya1b4TKY3NZahRHODvf3maYl4RTQY/XwuS4S+RJikPd+lDFr9rl/Pp7SCuph0lufdSgZwwBLnHU+yjTChrOtSQ+POto1Sx+Ni0atcCp1eMNGr/+vddJSiVsYoxbmSkJBjxbIp4m16KHgHETqIrxoKUq4JmmDT4lZVikgMwPSzP6GllBSk7j0fflCtYxSSKIN95VOjf9mfX3GvK6xHI+RZ+L3KC3m220nsG2ENunjTCMZKkTJWOhL1wU6rmWrvSQZKxmyucsPPHsZ8YdaFrbWBGRh9E9ukQoGIiB3lhl5Swyre4skm0ww07E6Oncn9HkNZr/AnBLdK2YqJ8RjgtNGejkwhMOsQUkN33dWD+jhf8RQwqlDO7q5LNlG28pv7swCUdqq5nn+vn8tnpeaRwdOI4QLp11GmHOZ0fhPm98kbe8mTiczm2OnIRaee17HF2Upci7yLn9qSZViMYmLYe
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY3mgg1a/e5606O0qRvG/7p/Seyq4L+WuA
- Thread-topic: [PATCH for-4.17 0/2] Ocaml stub fixes
|
This is a good use of the OCaml type system to ensure only compatible flags are shared in a list and not mixed between architectures. The macro changes are good housekeeping.
— C
Patch 1 is purely some a tweak to improve legibility. It's not necessary for
4.17 but it's also 0 risk to take as well.
Patch 2 is a change to an ABI which was newly introduced in 4.17. It is
suboptimal for two reasons and specifically does want changing before 4.17
ships. See patch for details.
Andrew Cooper (2):
tools/ocaml/xc: Fix code legibility in stub_xc_domain_create()
tools/ocaml/xc: Address ABI issues with physinfo arch flags
tools/ocaml/libs/xc/xenctrl.ml | 10 ++++++----
tools/ocaml/libs/xc/xenctrl.mli | 11 +++++++----
tools/ocaml/libs/xc/xenctrl_stubs.c | 28 ++++++++++++++--------------
3 files changed, 27 insertions(+), 22 deletions(-)
--
2.11.0
|
|
