[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86: Check return values from early_memremap calls
- To: Borislav Petkov <bp@xxxxxxxxx>
- From: Ross Philipson <ross.philipson@xxxxxxxxxx>
- Date: Wed, 12 Oct 2022 11:13:20 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WK0nTrupIYI1lFgGV+/w9IqfI57mNcQD5z3ndwApQjw=; b=MOocMEYr7Vmb6Fo/8qC/DQIzRddfRUIqhBsN22wbTnI745ZXS7c3DiLQUWlqgfWAIFV1v1QYyk2HjzonzYoLRuxSHY/Du02UgvfdQmvH+PD4b8Z1XGEaTPm+IwBLR2XD1xdejNp1kwQ8Mb4hDslQE55xFCZcy7a8DxBwVBTlNduwTW6Nm/WPO+peoTLENn1SZwPfNiOTLbeZ1e0MIEF05AmTf40KHpne91ld05icADyZSXcxNn9sKVF04Omfi9XPAaDZffle8lJKlyc6HyFMLCyNtMrFQjhmeJ0Jge6N3p5dmEHbW7BQwsoRiPPkJWWkF4VJhDbCO9c5b8tOrGZhZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPii7UeBvH8PY0rCaziiajbnegaOsnJ/N+fcztdFFb9tG7G9SAbRLSRi+bUHhZfu6sn1pbBucXWrGOVMtC0483SNFBTT/sqkFcN3juvlLxURbK8qI8o8NSHK0UdeWZulqtAjesSWTl8MkNo4IOyUd7NNGZePzVn/3MyegocfKbPKHousFPwGUvOT/9M6NdQeFtqoyoII9MwKOHxcR7pncEJsTfF49SMIAa+3YQZsWMDVMLpSMhF6Nml6vCcJoldF2UpYAUQNLogtLZFRvbDbPbl4S3HAm8SiIkFgATJKX9droMZMJvzdhEmxZFUhjqkBIg/rnEVePY7PWUd5/9JXNA==
- Cc: linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, dpsmith@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, luto@xxxxxxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, kanth.ghatraju@xxxxxxxxxx, trenchboot-devel@xxxxxxxxxxxxxxxx, Jan Kiszka <jan.kiszka@xxxxxxxxxxx>, jailhouse-dev@xxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Wed, 12 Oct 2022 15:17:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/22 11:12, Borislav Petkov wrote:
Adding Xen and Jailhouse people and MLs to Cc.
Folks, thread starts here:
https://lore.kernel.org/r/1650035401-22855-1-git-send-email-ross.philipson@xxxxxxxxxx
On Fri, Apr 15, 2022 at 11:10:00AM -0400, Ross Philipson wrote:
There are a number of places where early_memremap is called
but the return pointer is not checked for NULL. The call
can result in a NULL being returned so the checks must
be added.
Signed-off-by: Ross Philipson <ross.philipson@xxxxxxxxxx>
---
arch/x86/kernel/devicetree.c | 10 ++++++++++
arch/x86/kernel/e820.c | 5 +++++
arch/x86/kernel/jailhouse.c | 6 ++++++
arch/x86/kernel/mpparse.c | 23 +++++++++++++++++++++++
arch/x86/kernel/setup.c | 5 +++++
arch/x86/xen/enlighten_hvm.c | 2 ++
arch/x86/xen/mmu_pv.c | 8 ++++++++
arch/x86/xen/setup.c | 2 ++
8 files changed, 61 insertions(+)
Ok, a couple of notes:
1. the pr_*("<prefix>:" ... )
thing is done using pr_fmt() - grep the tree for examples.
I am already using the pr_* macros in the patches. Are you asking me to
do something or is this just informational?
2. I think you should not panic() the machine but issue a the
warning/error and let the machine die a painful death anyway. But Xen
folks will know better what would be the optimal thing to do.
When I was working on the patches I asked Andrew Cooper at Citrix what
action I should take if any of the calls in the Xen code failed. I
believe he told me it was basically fatal and that panic() would be fine
there.
Thank you,
Ross Philipson
Thx.
|
