Re: [xen-4.15-testing test] 173498: regressions - FAIL

[Juergen Gross <jgross@xxxxxxxx>]

On 12.10.22 08:28, Jan Beulich wrote:
> On 12.10.2022 04:42, Henry Wang wrote:
> > > -----Original Message-----
> > > Subject: [xen-4.15-testing test] 173498: regressions - FAIL
> > >
> > > flight 173498 xen-4.15-testing real [real]
> > > http://logs.test-lab.xenproject.org/osstest/logs/173498/
> > >
> > > Regressions :-(
> > I think these regressions are from the backporting happened yesterday,
> > see below...
> >
> > > Tests which did not succeed and are blocking,
> > > including tests which could not be run:
> > >   build-arm64                   6 xen-build                fail REGR. vs. 172547
> > >   build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
> > >   build-amd64                   6 xen-build                fail REGR. vs. 172547
> > >   build-armhf                   6 xen-build                fail REGR. vs. 172547
> > ...The arm/arm64 regression is from the backporting of commit:
> > xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
> >
> > The issue is:
> > In 4.16, commit
> > 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
> > changes the prototype of xc_shadow_control(), and hence the calling of
> > xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
> > xc_shadow_control() in 4.16 and after.
> So did I commit a wrong patch, or were the patches for the older branches
> wrong already in xsa.git?
>
> > >   build-i386                    6 xen-build                fail REGR. vs. 172547
> > >   build-i386-xsm                6 xen-build                fail REGR. vs. 172547
> > >   build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
> > I think the x86 regression is from the backporting of commit:
> > xen/gnttab: fix gnttab_acquire_resource()
> >
> > As the error message is:
> > make[5]: Entering directory 
> > '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
> > test-resource.c: In function 'test_gnttab':
> > test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
> >           (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
> >                     ^~~~~~
> Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
> I'm not in the office today, so I won't be able to do anything about it
> right away.
Maybe you didn't build tools/tests?

I can send a fix.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature