[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 4 Oct 2022 14:06:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m4iIA9BwVLc9QXtOKtR22v1ZaR9jnj1A2ju7nql2yZs=; b=l4ApXTXskdKROFPLSkNnQuNJSuyRBChiJuEoYHZICzOi//PSeb92Ivz+mOBb7nhzci1FIbqd7sUpb2ld16CVXzc2iUPWN76ki7k1vHyPP8RyfrXaUx1AKlRjRBYtNAfY1a8+ufVt/VQi1mZnOhHEIKgTWO2pXCnw1z/4XQjACMyGexLjot36Vo8cbjeJ0heLI/qxmMyBd+GU9dqGdCJ7GBS9gaix9/nDyOxLoACO+W+UtqI4aB64DXyP4CydmXVfjtFwhwNtGLFitjcaj7NgWhbXzjn8tgpRk1a+9k99W9P1g8YGWnc6mKX7XRSXbyKaQhefEfRtlg+aa1DJc44tQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6rwlMLp/kbN8OWP9SCX8+0Go+OrPwmLE5fryBH7eo3KQkFxqtMc4AUiL6h2IAbtbCJytTwNdNbAScwWTZKSJf9XuePcv34lYOOJo4wbpKkYxClb1H9r4LjqtEVJjqu4ZR0wI+Wde0fn/vHTig4+YUitQZ3rvFTVliPpC3p+IaSEJTm9rIHC8wEMLFGTMcvk813RAP9TOzgWGDZb5cWR+8Z3diblM06EZoGcbde2ZWRch39yT/YXhEd3JMJCPWvc91+6+nBT8s9KTIA6V4ZBKDfK1VAFFBGhcj9wKED5kTZI4Hj7XS+1mw0p8Po/vR3t5v5p3uiwF+5KcQSuI/5tjQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 04 Oct 2022 12:07:14 +0000
- Ironport-data: A9a23:eIwL7Ks8jGNaUPu0gaH6gCClxOfnVGBfMUV32f8akzHdYApBsoF/q tZmKWvSbv6DMDP9c91/aYWw/E4A65LVzt5mHlFt+XowRSsX+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI01BjOkGlA5AZnPagX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklO8 PYbeT8iPivdnsmsyuulUvQ9n8oKeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+WzHmmAdhNfFG+3sNPj0C9+2JDMhBVTWSBuMK0tmyead0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaGSUTN35EWiYCQiMM+dylq4Y25i8jVf5mGa+xy9fzSTf5x mnTqDBk3utDy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHs4ji0bnlePSxfdgw
- Ironport-hdrordr: A9a23:GaxI+aMCINTtSsBcTyT155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2cqYRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv70voxKhNNKWs2N 60TJiAtIs+O/P+PpgNcNspcI+QNlHnZy7qHSa7HWnHfZt3S04l7aSHqIkI2A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 04, 2022 at 12:13:49PM +0200, Jan Beulich wrote:
> As it turns out populate_memnodemap() so far "relied" on
> extract_lsb_from_nodes() setting memnodemapsize one too high in edge
> cases. Correct the issue there as well, by changing "epdx" to be an
> inclusive PDX and adjusting the respective relational operators.
>
> While there also limit the scope of both related variables.
>
> Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size
> calculation")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
With this fix sabro boxes now report:
Oct 4 12:05:25.087462 (XEN) System RAM: 32429MB (33208204kB)
Oct 4 12:05:25.087482 (XEN) SRAT: Node 0 PXM 0 [0000000000000000,
000000007fffffff]
Oct 4 12:05:25.171468 (XEN) SRAT: Node 0 PXM 0 [0000000100000000,
000000047fffffff]
Oct 4 12:05:25.171489 (XEN) SRAT: Node 1 PXM 1 [0000000480000000,
000000087fffffff]
Oct 4 12:05:25.183432 (XEN) NUMA: Using 19 for the hash shift.
Oct 4 12:05:25.183453 (XEN) Domain heap initialised DMA width 32 bits
Thanks, Roger.
|
