[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Fri, 30 Sep 2022 14:59:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMQpZm3HSu3S7zdP39USfEMSqo83saX/tKwg2Rhrdms=; b=WKRnCjA1qbQ+BdwNUDzL4Lufv1IZ3MDCoTDJA60GMCPS5rIVDauM3ck+dGS2T3ULSYhYmnhVqEwu04cor/Lu7aebh2K6QH6csPefIDoolDzqwPUweST1qm95MaFwAazhup1LsxtbLjnKm9Uk5i8FaRj2DFr8oO4kg1Ueku96pElSxYGRqIunAEX4i4V9cO66aFnKVYHziDdDnz++BhQxTO3OB4nrxq5ijMjY2T6b4ibb+eG/PSX8jNGJxCM3teWD2Sov0UH3T0JYCYryxp3in0AXjxESlHh4Lz6Up4iWOuGIoWouYhFIYCdWtmQhrsz3K1aohbKV/8g9WrkmsUtJUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFvcqo/1w+EvbDM0TFtnxi0e5RF3cRHUooUtf8byMwQOMMYfURUf2ntwUAqS0sykI8AveK9tDBaA9sXJiOeXXy1ygn9p5enKsUsLdJRjmECjxwZC7+qKKJ05zKDmpp69TAc/0Lz1fIbRRRPTzoYumyukp2pVeveMzdIrRVTBKwJjrxMCxin/XRCf3/xrT2gsjo9tZHGZQ/aE8WuhJwd++JFPMoGXXr6abcH3V21wByUe24QAWwKifbDDeOaTqJXOfGZGBEVkHz1BqAYV33F3oQGm8e3pgCBpBnADPRStDBiNTDRlcZqrk8zAZ/pMW/Dm4eDkdK0AXYIemVFW1CZE0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 30 Sep 2022 15:00:02 +0000
- Ironport-data: A9a23:FcLgmK1sgS8BTWb2s/bD5fVwkn2cJEfYwER7XKvMYLTBsI5bp2MHn zdLWWvSb66OM2T8LtsnaYm0phgO75SGy9A1QFc+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WhA5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVb3uBlXm9K8 sU9NWEqfE6bhOCn6Z2SH7wEasQLdKEHPas5k1Q5lHTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/F4/NpsgA/zyQouFTpGNHVYN2RWcRcmACcp 2TK/mvRCRAGLt2PjzGC9xpAg8efxXOnAdlKTtVU8NZGowSV7z0XFyEQbku/itCAj3CUaYNAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpZNU4uecsSDct1 1vPmMnmbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICUCHQ0M5oC6pJlp10yeCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs=
- Ironport-hdrordr: A9a23:bw7jka6F9XRANusjXQPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE6EbLAYYo/gNiuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY0mKHZPP9Gr0D7k+Nf4GjgykKFK3zc0sAgASidwA=
- Thread-topic: [PATCH v2 4/5] tools/ocaml/libs/xc: OCaml 5.0 compatibility
> On 27 Sep 2022, at 17:13, Edwin Torok <edvin.torok@xxxxxxxxxx> wrote:
>
>
> See below for a patch for that. I've included this patch in the correct place
> (before the patch that breaks it) in the git repository at:
> https://github.com/edwintorok/xen/compare/private/edvint/public0
>
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
I believe these changes are fine. We are now allocating the event channel
dynamically and this requires using a finaliser to free that memory.
> -ifneq ($(MAKECMDGOALS),clean)
> +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
> .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile
> $(OCAML_TOPLEVEL)/Makefile.rules
> $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli
> $o,MLDEP,)
> endif
Is this the right logic? Moving from ifneq to ifeq here.
I am not so familiar with the Makfile rules. The gist seems to be: we depend on
auto-generated Make dependencies that the Makefile in general depends on. But
in a “make clean” (or other “*clean” it is wasteful to generate these only to
later remove them. However, these kind of subtleties are obvious enough while
we are working on this but over time accumulate to Makefiles that are hard to
change. So I wonder if this kind of optimisation, while correct, is worth it,
but fine going along with it.
— C
|
