[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 30 Sep 2022 13:35:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=FQ2rVT+qHPoaUfvuedma58hhky7iDvPK1EVkjx7hawBoAcchH5gH8fASq51XC9ez0Tp3WiaBu8vRPOIjid/pDICE60koAo5PVy7wm5UO2mKSiI65UL5ZRNhwnMC9EShKXgRqQ6X3GyYy3f7SeYZEfltHMPIzBN4hHuH91QlMVRcgrOF1ujSzjxtQbODiUmte1VGTcnUiR2TdzDvG5ZhWl19Bu5Y29m6XMdu75Ci5QXt/UgB1RX0kwQ+kdQ7fJSzcuh6SuvSyTCfFjLHaioHslqM4ZZp1P3OKrdHpr7nzrqyUKtbhWTtpE+M29MVGsni2V/+YbuMjvvlXSj8WOG7oZA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y+lBaMls16rVioLuUsn0KwrXVphZcG9st/d78u+DP8=; b=bR4Fs+e6fOFZLliXD72lBR5slaAcFArXBLJQdOzJEdXbfFQ3I6ZYnd/oSlNXoysaPL/ynsmTydqaHTig4fAplSjeUmkCgwbtYLAr48EXA2G2niCy1aJceoT7Cbac8NInnLDVLqhVZA8cDUXdK/oHguaZXzu/V1EI8KFpF94h1HfXRqfB4scj3MnxvzTwG1rvf8MwfT83rLnJdM9jg5wROexNFDH5/b9ipbshDKQlkQ+QzBCdBM1hTbF4wa6agsjrGXGmNk+93ovuKO8E09JVipmC9a9FAGC2GqHb6rvJ4P5Aki/HWYndDcVocUayCwbVlpKyziM5bqmrg+N2iihZBg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=j0E8Aj23k9p9RmM1BVNGRYDOxgRxHSjFk2GaPHlJiilPiMqSToCwoUHADIUYB6KNsr0119CahAMI5wcG1l98gWFy4QNEvxsOW+HHpgmrg+Q45hCs5ko/kQG5AaHjameMYdCIxZZseXSjNKsHl2LilzdoV0dm2nqEOifgtKedTmEk4dtwKE9Yy4KdWsfeUi07Bcx7sThVZXLp5wjbQrm1lYtp2CicAi6l1j3v4C2pevraxjYinsKMZen3v+GONWYUxWL7JxjrTXVNs/ySiOiZUHCeRhCxvvldFTQSdh8jHleaI5tJzRRXBHZiH3hRzXi/5xlzV/6MCamvlN2rvWy+ZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsW8GYKVLOb/jIixFNXrWjukyl6FShddFtmx1/Q9qHEnp2O1Bbr0Tqhv3/T2qyMYReVubV1YEi3dNAxl7FXi5/9qIokp56NmPM8EzAjl30hrowEUDxd6M1/3D1R/czmBAxi3QVpBDHuKmPIb7CmwI8gzBeS+PdzGgMOoTIkGdE2xFgW/10yjySMcB4dQ6/LEKsK2HqoVYWpz3FbtpIQ8wEQ8a/9VxJ4/g4EWkhP4LKVZUpplebxeDct+OX+DKfIA0yCqnut7jL6ebccJlD66PX+uEahbHkyOG+ciBVL48tgqIGt/00MNGF3Rez+8g+XjBt8DrCJpkTTy58RbsivGww==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Fri, 30 Sep 2022 13:36:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY1KFdAull5ChokkeaXft6EPXQra337hgAgAALwoA=
- Thread-topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM
Hi Andrew,
> On 30 Sep 2022, at 14:53, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>
> On 30/09/2022 08:50, Jan Beulich wrote:
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there and hence that type's handling can be left alone.
>>
>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Isn't this also liable to be the root cause of the crash reported on
> IRC, where a read-only page was being inserted into the heap?
No this should not be related at all.
Cheers
Bertrand
>
> ~Andrew
|
