[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access(
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 30 Sep 2022 07:46:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=IEeyP/XwjkcZ9u6ljFQ1e+ZNsWHUyABoLoibdSzAd3SObBRhbW2qnR9Lal7avj+nxW4oUqYCiF55JjFjKQis/KzXeteCwM4WiCh+6oFLG2ekL1A5kGj0Q4Xni9RU0MTxUw/LlWkubKwVndz1cyMqDPiYP0BT3xLmSU3ZxGFbEuwmsMGn3izaP3fHb+4fKXE2ATFWnR2+MSnJZ1rFVite3S/LlBGBdzztHcbLuhulBZanZy1tCrnJzvj2q2Eyaev2Q12Upiy2CzcasMbmdolgCbSMYQTRKX6SSkpTWg/Os/RfvypXAzHqQ73wR6+rxXWOUoGCb9ZcKrwZw5wMXJFFfA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duczp9xmZ1EtJaoMyzJypPcQrxGkGzVNp++Mc8qTau4=; b=iD6kPTdinW4nk2vGBRlKp6fOYgCOGarIAnEe4F5ZlN834jxYDPquFP4qBJD1+p3zej29h6gWC1SY9ktTeOO84w2YZorPQVu3kPRpiGtqLxtCAcD3Uolrojq15iiF9KJ+BXhQxcK8B3WrZ3vZjN8Ijq+K7KD/ZQn6zLQBmW1TIzkzZO2GzcETQig95J4qNFxj4kPw/cBLQclo9TdfHgyTQVpKYuidpK/1lH90a0/5qkbYXY8xn1vNagOXv+XeYKlm11hfzpjOgUuuJi0Tx8mDbmcUCIZubBYTj0RvlQn8VSjZxOwPm7o8mXsqbRjz2J98IXlrGwKd6rmWMNbkaHz4gw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CxV5N4XlJEWIvnXf/0sB4SEo/zwhrdIR8obLbJxMoKUds7Ss04iIC9vHum5RPhhiD01S/cTYkOz9tGTNP9UPZffGusM6HCvKIZD1J4fYpgXov4zS+L64/qBeSvN26HybUMpjX2LpfOMr1tMcChu3Yr48EYbLoS9AeqyyZm1CnfdKb2Ewd8E8DTw4A5iLFbU5ny0pRT4qEywbaNlrvrcFxXvy/7Lrk7HOWiheR9smKTeOlIfzR+R85tWFA1tczkDJWPAZ47duXMV0H8UadIf/ttXF6hZ/yKcEzBSTXiuEu76RinVP3I6b3bwd/8RVj7IJwQIvjMtdfxtN2cIlA6qH4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLmnM1ceSkbAwwoRw5dzOelsF3yMuKpr4JG0dx4+2boNq6tdvwIMAjYlDBulnspTO3R+m+MmgmFTL27xADl28HaRj5d/Q709UDl8DOJ6QwThUhVx7lNMRZZqf3FzXwSnFpwm5+80CqZTaC56ms1EQ+XtICQadeRTHrD5WamqAkhJsJUg+HhGbWaFJGvgnq0qHAH6Yp0Afv0bleywn8RYbzPuEBXsf+CZnW3N2LNHvPaC9upYbnyHr+EDZx78HpX3eDV9IIKD7UdRMIFb4B+p53SqHRE9euYM1tEd4cQreZcP2Ti/iAHvaasO7PGB9+CW+TDKxlMa68NJrTeByFYBVA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 30 Sep 2022 07:46:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY1JW5H0TZSlF74UKUACaulgO1oa33mGCA
- Thread-topic: [PATCH] Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access(
Hi Jan,
> On 30 Sep 2022, at 08:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute
> from gic_iomem_deny_access()"), the issue really became apparent only
> when iomem_deny_access() was switched to have a non-const first
> parameter.
>
> Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -892,7 +892,7 @@ struct pending_irq *gicv3_assign_guest_e
> return pirq;
> }
>
> -int gicv3_its_deny_access(const struct domain *d)
> +int gicv3_its_deny_access(struct domain *d)
> {
> int rc = 0;
> unsigned long mfn, nr;
> --- a/xen/arch/arm/include/asm/gic_v3_its.h
> +++ b/xen/arch/arm/include/asm/gic_v3_its.h
> @@ -139,7 +139,7 @@ unsigned long gicv3_its_make_hwdom_madt(
> #endif
>
> /* Deny iomem access for its */
> -int gicv3_its_deny_access(const struct domain *d);
> +int gicv3_its_deny_access(struct domain *d);
>
> bool gicv3_its_host_has_its(void);
>
> @@ -206,7 +206,7 @@ static inline unsigned long gicv3_its_ma
> }
> #endif
>
> -static inline int gicv3_its_deny_access(const struct domain *d)
> +static inline int gicv3_its_deny_access(struct domain *d)
> {
> return 0;
> }
|
