[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test



On Tue, 27 Sep 2022, Andrew Cooper wrote:
> On 27/09/2022 23:47, Stefano Stabellini wrote:
> > On Mon, 26 Sep 2022, Andrew Cooper wrote:
> >> buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler 
> >> patch
> >> which is relevant to CONFIG_XEN_IBT in 4.17 and later.
> >>
> >> Force it on, rather than having 50% of the jobs not testing what they're
> >> supposed to be testing.
> >>
> >> Fixes: 5d59421815d5 ("x86: Use control flow typechecking where possible")
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> ---
> >> CC: Doug Goldstein <cardoe@xxxxxxxxxx>
> >> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >> CC: Henry Wang <Henry.Wang@xxxxxxx>
> >>
> >> For 4.17: This is bugfix to CI only, to avoid it producing a false 
> >> negative.
> >> Currently, the test intermittently fails to spot the error it was intended 
> >> to
> >> identify.  It is very low risk as far as the 4.17 release goes.
> > Thanks for the patch! Very recently Michal has added a similar
> > EXTRA_XEN_CONFIG option.
> 
> I know - that's where I sto^W borrowed the idea from.
> 
> > If you are OK with it, I'll rename
> > EXTRA_FIXED_RANDCONFIG to EXTRA_XEN_CONFIG in this patch for
> > consistency. I can do it on commit.
> 
> No, that will break the fix.
> 
> These are not options to be inserted into a regular .config.
> 
> These are options passed to `make randconfig` via a sidedoor (the
> KCONFIG_ALLCONFIG= variable) causing them to be handled specially while
> the regular .config file is has it's contents randomised.

OK. I committed your original plus a minor code style fix.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.