Re: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Tue, Sep 6, 2022 at 8:45 AM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
>
> On Mon, Sep 5, 2022 at 9:50 AM Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This enables stubdom reliably detect when it needs to reconnect QMP
> > socket. It is critical, as otherwise QEMU will not send its handshake,
> > and so libxl will timeout while waiting on one. When it happens during
> > domain startup, it can result in error like this:
> >
> > libxl: libxl_pci.c:1772:device_pci_add_done: Domain 3:libxl__device_pci_add 
> > failed for PCI device 0:0:14.0 (rc -9)
> > libxl: libxl_create.c:1904:domcreate_attach_devices: Domain 3:unable to add 
> > pci devices
> >
> > See vchan-socket-proxy commit message for details about this reconnect
> > corner case.
> >
> > Stubdomain side needs to use --reconnect-marker=1 option too.
> >
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Also
Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx>