Re: [PATCH v2] xsm/flask: adjust print messages to use %pd

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Wed, Sep 21, 2022 at 11:16 AM Daniel P. Smith
<dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Print messages from flask use an inconsistent format when printing the domain
> id. When referencing system domains, the domain id is printed which is not
> immediately identifiable. The %pd conversion specifier provides a consistent
> and clear way to format for the domain id. In addition this will assist in
> aligning FLASK with current hypervisor code practices.
>
> While addressing the domain id formating, two relatd issues were addressed.

s/relatd/related/

> The first being that avc_printk() was not applying any conversion specifier
> validation. To address this, the printf annotation was added to avc_printk() 
> to
> help ensure the correct types are passed to each conversion specifier. The 
> second
> was concern that source and target domains were being appropriately reported 
> for
> an AVC. This was addressed by simplifying the conditional logic.
>
> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Replacing domid=32767 with source=d[IDLE] seems more user friendly to me.

Thanks,
Jason