[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device


  • To: Paul Durrant <xadimgnik@xxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx>
  • From: "Ji, Ruili" <Ruili.Ji@xxxxxxx>
  • Date: Wed, 21 Sep 2022 01:19:36 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQSCFEVGlbV6AIA31BdYy0G7kngG8aXhhIxABFsbBDg=; b=m/Rv5w70eBmHPu4MLsXrHBr/zRiexTja7Koms/22cpsUiGQtDe01K3GQlTtu3WV/BtEt5ANbgElS9GijjCo+HtRzuNY/XrN2TZKCDq1j3UGSgrEUvkSQqZTNePXDCremN05Aypdnno4TxE2eE8DR9JYkDDcZUVCvBWnzcs6jI6AIfZ6i2TvjDXZOgH4JdLohyF8UNmWbV02oTbQSjh9hHNbFaOmoKcfe3KuTCN11HK9kdfdDjj4bcmrtXP7jzCSmu5sKJF8CzAVde4p9/yXjQ8xPZbX3UA9nn084mHSUndrJbwNs5AnhWxBvLxnUoU76U/C5Li3gAlWi8+w82xYJUQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q9EiOL/7a6kpKMD6HExfdHOZgQudH1+mcPtUomtQ0l9X4MzRb8GBotpB3XMmWpOCr5ZtQdV4gJeRNyJhaiahZT+GHy2mJ0DaBoJzEUqUj9/haxFU6bVNItHvvPuxDn869i9iVhdY5vmTSmBAztqRfj7EdP/C9e+cZCQSm7tAp/bfiqech4OREpBh7BnDrpVJTvncvtf1v9Zhg9S/ePxqZRtpTOMR3olwq0Ar9uHPhSqyQKM358SNVZQT2atq8uSewcMtpK4mfkZPiK1cG2EVn76RqKp3yNr72KWVPY/i/0PMByPL6coboHTbhcfhATKuYZzpx4kWVIPuFFoUUqp7cw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "Liu, Aaron" <Aaron.Liu@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 21 Sep 2022 01:19:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe71ddb2-53de-4503-92e7-b763c759a0b3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-14T10:04:41Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
  • Thread-index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9gATHwuGAAP0mxgAAB/V+QAU1c5pA=
  • Thread-topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

[AMD Official Use Only - General]

Hi Paul and AFAIK:

Thanks for your help.
When could we see this patch on the master branch? 😊
Our project urgently needs this solution.

Thanks!
Ruili

-----Original Message-----
From: Paul Durrant
Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device
On 14/09/2022 03:07, Ji, Ruili wrote:
[AMD Official Use Only - General]

Hi Paul,

Thank you!
But how could we merge this patch ?


AFAIK Anthony (anthony.perard@xxxxxxxxxx) still deals with this.

Cheers,

  Paul

-----Original Message-----
From: Ji, Ruili
Sent: 2022年9月14日 18:08
To: Paul Durrant <xadimgnik@xxxxxxxxx>; qemu-devel@xxxxxxxxxx
Cc: Liu, Aaron <Aaron.Liu@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

Hi Paul,

Thank you!
But how could we merge this patch ?

Ruili
-----Original Message-----
From: Paul Durrant <xadimgnik@xxxxxxxxx>
Sent: 2022年9月14日 17:08
To: Ji, Ruili <Ruili.Ji@xxxxxxx>; qemu-devel@xxxxxxxxxx
Cc: Liu, Aaron <Aaron.Liu@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


On 13/09/2022 04:02, Ji, Ruili wrote:
> [AMD Official Use Only - General]
>
>
> Hi Paul,
>
> Could you help to review this patch?
>

LGTM. You can add my R-b to it.

   Paul

> Thanks
>
> *From:* Ji, Ruili
> *Sent:* 2022年9月7日 9:04
> *To:* 'Paul Durrant' <paul@xxxxxxx>; 'qemu-devel@xxxxxxxxxx'
> <qemu-devel@xxxxxxxxxx>
> *Cc:* Liu, Aaron <Aaron.Liu@xxxxxxx>; 'xen-devel@xxxxxxxxxxxxxxxxxxxx'
> <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> *Subject:* RE: [PATCH] hw/xen: set pci Atomic Ops requests for
> passthrough device
>
> FYI
>
> *From:* Ji, Ruili
> *Sent:* 2022年9月6日 15:40
> *To:* qemu-devel@xxxxxxxxxx <mailto:qemu-devel@xxxxxxxxxx>
> *Cc:* Liu, Aaron <Aaron.Liu@xxxxxxx <mailto:Aaron.Liu@xxxxxxx>>
> *Subject:* [PATCH] hw/xen: set pci Atomic Ops requests for passthrough
> device
>
>  From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00
> 2001
>
> From: Ruili Ji ruili.ji@xxxxxxx <mailto:ruili.ji@xxxxxxx>
>
> Date: Tue, 6 Sep 2022 14:09:41 +0800
>
> Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough
> device
>
> Make guest os access pci device control 2 reg for passthrough device
>
> as struct XenPTRegInfo described in the file hw/xen/xen_pt.h.
>
> /* reg read only field mask (ON:RO/ROS, OFF:other) */
>
> uint32_t ro_mask;
>
> /* reg emulate field mask (ON:emu, OFF:passthrough) */
>
> uint32_t emu_mask;
>
> Resolves:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> ab.com%2Fqemu-project%2Fqemu%2F-%2Fissues%2F1196&amp;data=05%7C01%7CRu
> ili.Ji%40amd.com%7Ca5e2c22a81544feb6bb408da96309702%7C3dd8961fe4884e60
> 8e11a82d994e183d%7C0%7C0%7C637987432689748212%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%7C%7C&amp;sdata=Jg8588FWkIZzmSEyt50TYCbck2NuoVJdm7ZP0Z%2FtFGc%3
> D&amp;reserved=0
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> lab.com%2Fqemu-project%2Fqemu%2F-%2Fissues%2F1196&amp;data=05%7C01%7CR
> uili.Ji%40amd.com%7Ca5e2c22a81544feb6bb408da96309702%7C3dd8961fe4884e6
> 08e11a82d994e183d%7C0%7C0%7C637987432689748212%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&amp;sdata=Jg8588FWkIZzmSEyt50TYCbck2NuoVJdm7ZP0Z%2FtFGc%
> 3D&amp;reserved=0>
>
> Signed-off-by: Aaron.Liu@xxxxxxx <mailto:Aaron.Liu@xxxxxxx>
>
> Signed-off-by: ruili.ji@xxxxxxx <mailto:ruili.ji@xxxxxxx>
>
> ---
>
> hw/xen/xen_pt_config_init.c | 4 ++--
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
>
> index c5c4e943a8..adc565a00a 100644
>
> --- a/hw/xen/xen_pt_config_init.c
>
> +++ b/hw/xen/xen_pt_config_init.c
>
> @@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
>
>           .offset     = 0x28,
>
>           .size       = 2,
>
>           .init_val   = 0x0000,
>
> -        .ro_mask    = 0xFFE0,
>
> -        .emu_mask   = 0xFFFF,
>
> +        .ro_mask    = 0xFFA0,
>
> +        .emu_mask   = 0xFFBF,
>
>           .init       = xen_pt_devctrl2_reg_init,
>
>           .u.w.read   = xen_pt_word_reg_read,
>
>           .u.w.write  = xen_pt_word_reg_write,
>
> --
>
> 2.34.1
>


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.