[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 10/11] drivers/char: suspend handling in XHCI console driver
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Sep 2022 17:07:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FLQZ1v9tg6/y3zJlbU3z5OIg0nk4F3+Y+hEuVefgAtU=; b=Aoje1JYvo/FgzrvD3tr0THMIBRGGTOCDRcTH8lda8Mt4kc9mHKqbIlyNOv7I+kEHnflkx3isNUiqEFuw5M2mn4qDKH4Szc+u/5YYoIe1j5Qn0snZ2YMpI6phj9Fh9SgcoKO81ejWqmBNlc2VJNKmPMLkoysoTe+X0rssfZ+b4gWyhkvnlyzv+TGzeGentB3ZXE7zsCWO9rG0lwYjqk59dNcuQgcGzfZyWScNz9Jw0uMDC9ESQswErqkUI05hd32682+1IfEsnG7oXsJ/x7H1a9AgKWnuMX9b8fL1iulHQCMNS8Q9yf23l3XAG9Ipox7pbIcIGCO+NVm7udIJELPoGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcQJZ2nZGwIFja0/hZKWunTk7fDzpl0Q1Xy/PqbfdZrcfpJ0wR+Qhy26tsfP3esQkpN2SWJd62xL3/pHWSQ6xtsAMNbJSsZu9JzrRPdgm93+xWHlZWI7MKTweCwTLSZlbEGfdqceyDa8ePcf/WWogkPjmAqIzEbW6RBEOfgU4PBgZod8auxC3XNgnns4+DPJT/O+GCizK5+85pNiif4T2SyBFbhKSS4Dtk645bN7pcrxVbHhZ52pc/aTiA0LtKncAxMiwoP2uPPO84Gqt3VD3P28yzXny9KOYNFhCDSCLiHFL5fi6sRHS0NMT1r05LcZ0vBj7gLXFTGtdOoROt+ITw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Sep 2022 15:07:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.09.2022 04:51, Marek Marczykowski-Górecki wrote:
> @@ -259,6 +259,9 @@ struct dbc {
> bool open;
> enum xhci_share share;
> unsigned int xhc_num; /* look for n-th xhc */
> + /* state saved across suspend */
> + bool suspended;
> + uint16_t pci_cr;
> };
While perhaps of limited relevance right here, may I nevertheless
suggest to move the new boolean next to the other one in context.
That's both to avoid setting a bad precedent (of not using available
padding slots for data like this) and because imo the comment also
isn't really applicable to this field (but just the other one you
add). Preferably with that adjustment
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
