Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Sep 20, 2022 at 11:06:57AM +0200, Jan Beulich wrote:
> On 19.09.2022 17:09, Marek Marczykowski-Górecki wrote:
> > --- a/xen/common/sched/credit2.c
> > +++ b/xen/common/sched/credit2.c
> > @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, 
> > unsigned int cpu)
> >               *
> >               * Otherwise, let's try to make sure that siblings stay in the
> >               * same runqueue, pretty much under any cinrcumnstances.
> > +             *
> > +             * Furthermore, try to respect credit2_runqueue=all, as long as
> > +             * max_cpus_runq isn't violated.
> 
> This last part is questionable, partly because the command line doc is
> ambiguous as to which of the two options is intended to "win". I guess
> one needs to know the original intentions to resolve this.

Right, I've chosen this approach, because you can still emulate the
other by setting sufficiently large max_cpus_runq. I can add doc
clarification in v2.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature