[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v3] build: Fix x86 out-of-tree build without EFI


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Mon, 19 Sep 2022 15:18:02 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Chen <wei.chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 19 Sep 2022 14:18:17 +0000
  • Ironport-data: A9a23:LB6noqse4Hfd0/kgdGhtqaqJ+efnOphVZltV8MifNqXetXmJ2xPK1anx4FJ00kkjnHarUPUpu5siBHQZlyfxrspDZzCHZc7qtvZeKG7bGsruekzRALxkPUs+UEpRX5tPcWw4MrWR7Z1jU+m5SDYjuwQRJk2sOo7jg/e0qpvFJGU6U+g91+TvQLqyea/gpW2GKdll19h8e3Jzs7ZaonkIV98nSTypaw3fPgBMi3Y+ioyYdX5s86sOmIL3ek1imlPPu3/QtoHWjAKpQeZ9mqm8bV1b+ryeFcCMhpDvcbBLHCpB74ve/rtrNh0kk9uvZGP7gdDCzYHwVAAEgj3oLzTaBuiJEk81CsLFSmOFJ3hf3GuLTiKh6WO3dJsXT6aBlA3PQS//6GRDSE0ZYbe16ko6ODWyCS87HxisgHm5czo2P+BFP+YMKw6/MNWXbIy55QxV0g16O4oMC+aQMIjqg/Y3GscYRvL+u4sjN6WKB5mRqx8fIwjPKqf4GJoJHUm7sEqVMRhALKyrRazKlkjT1g5wGR5c0QgT2bL0c28g8MiHGTp8zDGWlHmcVR+60w0b7OC34PuN2vvNUsDdEvOYpBSvsnHHr5Bj1hlVG6mNo6VsHlBqbreOtIJVdT3ngAxoFkcM6PhVf02o7OD9b8vpfIV60IDDmkxPmyZWUlIJ46W3FqhpS5Tmn4s5iVSnsPUetO9uQ3H2RbGGv6MLguDzr5G6qHF5O0bmytbc5UJPHUSo9e8zV/e4B6lM/XPQXl6zQMxslFLgzNqPgd395dj/gu9kn9NUsK9l3ifoKti2e03TrbWvqgVdYCXZhPa66x5TUPzwsBv25lpozFqP33Xanv+t6HglEbpMFiVha80+AiQgQ5XGmZF4cKdOZ32I3PlO5NZssxSB1LftNAUFJUy/tqNSOSVbmMPjjjoe8r0lAjGPYzTqFvkwbxB9b1lXYqUdXR3EjV9OVYuhKACeWZFDQ2F7bE6m2NI5Xwi8ekk6vrDNnrpcmHQpwuyHOwgOX/QOQ9jxxwwEjWLSQDknlf+5D0zBBorJ82J8K2+kt4RfKgRa7YuSekpi5Br4BH444Htpc4hX7knO0V3rj/ZtJP++4K7NCBjyCoO2gJI/P97Hg31Jzvl47DwMEI7iiELFAdjnzZxQeOmZIXZNFN2yxwQW9me4cKN1HKphpP1VKhwUATYq/xQa1laV43OVilpX5PviGZ/hbxIvNK5Q+Uhl+zQ/7DhCT+Ei9pMUF+C5l1lH+E+WtX6XvYJI11yGCbB3idfFHeE6I9hM/NwwryfmU1YNdbb0NFQMbaBqAoKjYwZQ799htQB6g5z6ZjuYGR4arqedYIJTMiwHAdHKEYipdxVc6XHK4HtFcp2JtAni1tqC9D3S3FNEAPol4SOYPWGuXwUvNmrOur99A46jpk01l+CtBI6jACKaVFX0gxzdXgDZV6kmFMIalGnP5dYiLxtcftnYHUGqNBdhPDiJowFq9Scybarwb2GFeDpOJ3XeqPIvpj8badnx7KiByH9ry7VPl2LLVdWt6CzEizLIDNx0Mb3yk4A6GFgqGoVGanA4rxfBY1/Zi7ZeMFN5/oOmMR3bRAusbiQtsAufZZl74b0KMZdJm6/Iy+6Bfj5vkvWeAyN9MD3hEywVLaKvwZRrZX0yh/v3pp1MeCQ5zlQdUYXMaWO6rTTT3w/IObS94fRG3EFPqc2YQ9pE/sc1QP6Crc6FzPDMOsuStPWkiKDN23NvV879WeT/24ZmFNoLEIszzBp2r1KF56gmfVu+zhfrX0MpXj5zO43d4TZ0Z0zECBn8Muj19v+kDTbMC9eqhzFFSk6ULqDSJqp5X4G3OfiCdtDaw9BJTx/5fw5mVuNsKSWWzDEEF0/FRZ+FhUoRxfob1Qd565MfrLM37ZMGrlc9nNearGv+V+g05vz/nVvHGanrCeKtclkN/rPVcrf74wvfnWh5o5A1iiUOQmBRaCo7Y/vOIYYJRJgVk2qttBG0BU9pNS1GpuQ/a/lB2WtwfvhJ68tgrWkgbUhqE4UYpWQa4b+WaICFQ6eWcT9m72QhCupYPIhsZDh2NkrBS333F/Ovv/viuZhqJYX7UtGpUE3tM0NXpVuslgENmwSAFiBvLZCgdVLmuX3K4yzarXejR8E3N0WoxBp9ma+HlK/GRNoOGtLqCvLt0n1kvId6h4JBMXgYtTd0LZwhYLw3lUicr4riXtL1t+cQX33TQgvh3fCef1iKeWtMwefWVatAfvD+WYM7pnEL0ZrMQQNLDmcs+F0fjqU5gvyl+bwfTbQzaJy711pe3ZJw13cHEmP2jvzniwHkEVG/bdMlMAuq1VCFMYSQc3zjpuufl3NCQr5jxLBzjH9/7s+92ouGjoIBn4Tzw57p28++fA4pc8sa1nw2KCvNz3cpuTOp9uYoFN0tpvHOXLpBR83sxyGKQV0UImvnHkoMAgjTu5KqOKoC4DNTxXmoELn2SYNmdHeI6RnyZyu/d5U3ghNDUaIBYsHQx0x5FwZlIfHqo6JaKEf5PnQ5Qt0ifZdAe3KBdq5EdVsYvXq6w8yM2PaYtPkcaxznLxhO5fLj/DvT3S7C7K4/1WUwWdt3SK9PLabq7GXz6I6yWVfSojd+XiG2aJrCfJr7WVHmZ2BoDTP9Kqb1fjIlDgua2/VxNgMvUsWpPTSLRs02HIxbqGzWgItMUtN1WhObK+0MP26dYROEm0+X0dOMwMHg35KYOybw2dXnYV5aL+RPFu2POiQQCPxkPvLZSwUvSQM14Emko09rw4ro/rdujQomJkjoLt357BpP5OFRcZdIVWCMYEViQ4CzzwqG0SAvisTxyV2Ti2ncYG24dXYB+kX21Q2zLBeI3smFJ4Zt5zgmAB3mY8GVr+TanHyBlKtM5PWwpI3RRPoMRS1PRhAD7hrxJBLVGvkI5/IxjwFFjresyrsAzyG6APIB5NXFA0XeOXEZpE+r5NWKe84p0hmrOvY6UHF8hgy/+bFSyFchhrRsscyJQjhVOh/9DbdMij/Am03Z/nVhYrm2FDvT9v1RcYQGng==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Sep 19, 2022 at 01:02:52PM +0200, Jan Beulich wrote:
> On 19.09.2022 12:28, Anthony PERARD wrote:
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with a remark and one more adjustment:
> 
> > ---
> > 
> > Notes:
> >     v3:
> >     - back to using common-stub.c
> 
> As said in person, I'm a little puzzled by this, as the v2 discussion
> had no hint in that direction.

I think it's because the discussion continued on V1, and I mostly follow
that:
    
https://lore.kernel.org/xen-devel/5d926715-b6af-234f-9798-622cdb53f181@xxxxxxx/

> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -280,6 +280,7 @@ xen/arch/*/efi/ebmalloc.c
> >  xen/arch/*/efi/efi.h
> >  xen/arch/*/efi/pe.c
> >  xen/arch/*/efi/runtime.c
> > +xen/arch/*/efi/common-stub.c
> >  xen/arch/*/include/asm/asm-offsets.h
> >  xen/common/config_data.S
> >  xen/common/config.gz
> 
> The new line wants inserting a few lines further up, to retain sorting.

Oops, forgot to re-sort after renaming from "stub" to "common-stub".

> Can perhaps be done while committing.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.