[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libvirt: disable Werror for non-libvirt flights
- To: Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 16 Sep 2022 10:19:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RuY1MuLzIfClvyxlgwYR0xCJDqZXV4AXvdQHK3qP7HI=; b=aAU2ZePBaI4MD81B8+EOJ+0l3OLRJyN+moomPaNc0Xa4lVhSTapQ5OI8DnsvdC7fbArS3mpD03bMm6BDxL9qiWtSDDY5mNql7wnFqAgiT/AAnWPkB0e37s/bq1MOoI4bYtiRUFht6g0chMxb3qKjIkZ1ykxGVdS1uZxvpvtrPfG1uMwrdNSxK4SLqy1rlosy9kFEFFrS1YU0PJIi6RgS+JWJKVucuqAgTQZ6+fYk4i2gcU1+zO8S9FyHtAgSDEdo+2peaHIf/6nD0E+buLKWj/vb8QkXHsjoE3c3zHX92NV0/vD31kYU6guWIXp4RVQsefEEBrd9mnQRdoetxRI+eg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzdOaPSDQ4ALuwbRS1oH5LjU48RU2BBW7PjN+hVHAOeMJf7FQ71BXdVb+IgBeWyQ/XbiTk4ETyarkrLac5a6LAeaeGbapHq3/AZsNobRz+OZg7uV55OmBrKEaIFaRt8LioSQvAvkkzV+WOPhqMs1uJvZ6DtxYm9VHrP7YaN/ODmvX2gCvZ/SzsRSNzv+j/lCkn2G1ATGAA45fa/cVOyuORWGcCEZRECYgczjc72/HHpSKlFwhrhOY+2BtB110JYzI5casvE+AqTggxqXRqzu7m1mNk9Dcabnx+k17UrE8ZZ7xBs9+kajU+ZLqOyBCt5PWnUQ6TspUFh43zDiiHfaeA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 16 Sep 2022 08:20:05 +0000
- Ironport-data: A9a23:SwRbsa2wPPqW69M4H/bD5f9wkn2cJEfYwER7XKvMYLTBsI5bp2RWn 2JNCGGFbquKZjPxftF0Pd61pENUv8KAm4JlHQA6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8U035ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/9KCmQ6Y5wpwe00Plh10 e1fJTMtSTnW0opawJrjIgVtruIKCZCxeak56jRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2yS5KmIAwL6WjfNfD2z71gt+3aKrKNPIUteLWd9UjgCTo WeuE2HRUklBb4zOlWTtHnSEh+juzSX0ZK0pLeep7vF1x1aP+0cvF0hDPbe8ibzj4qKkYPpeK UUf+TEpq4A59E2iVNq7UAe1rXiJuBJaXMBfVfA5gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+ITXOQ8J+EoDX0PjIaRVLufgcBRAoBptPl8Ic6i0uVSs45SfHtyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g UU=
- Ironport-hdrordr: A9a23:cqPALKjp/o3C4+q02RZ+vvmaFnBQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Sep 16, 2022 at 01:20:11AM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH] libvirt: disable Werror for non-libvirt
> flights"):
> > I don't mind using -Dwerror=false if that's considered better. Ian, do
> > you have an opinion?
>
> No, I don't think I do. I think it depends on what kinds of things
> are likely to change, or go wrong, in libvirt.
>
> - *) libvirt_build_runvars+=" make_njobs=1";;
> + *) libvirt_build_runvars+=" make_njobs=1
> meson_options=-Dwerror=false autogen_options=--disable-werror";;
>
> I wonder if it would be better to abstract this away and instead have
> a runvar like "libvrit_build_werror=false". But maybe that is
> gold-plating it.
Did consider this initially, but decided to use specific options for
mesa/autogen in case we need to add further switches to specific
configuration systems (unlikely I guess, because autogen won't be used
anymore).
> If you choose to keep that the way it is, then for either version of
> this patch:
>
> Acked-by: Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>
Thanks, Roger.
|
