[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: enable interrupts around dump_execstate()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 13 Sep 2022 16:50:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oXgEM/dC8I13s3+hejb49goh+TWzqq46wAWupbDUo7A=; b=JnojP1ncq8vEN+CnEPFAWTqa+p54TVmlgLf+c41R8od+QIjH3EuhQ0tZ2hvnMXQsyP3N/PfmxzjKQ3icPfrrcV8AGot7TqizJbssXYldVhxG2Y/rpTqu7K42vPGKvfHWzzHt58GsDzHAFayRDVFH6cV9QmN5ddBCy9F8aDdN/a4OCFteTjOEnihy29VYIYSxmY9v+zExdR3zaujJ50GDIbKmntJVHCF9OVQyYuRdD+f8A7iHapn4cPN6EwlwJ0B+r+PTEcBGR2O5bElhL597rM/bm55rpfvH4r7FGhkj7YABq8r5c+E66QVb3RmLClxFMJBaUBlYy/shtlirgbuN6w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WtiAaPke35y7gFzu8QoGUuc5RxEM1uIX8YjM+kgDIW8xBQC67vzPY9bCbrIGdETSMCv8zg+rI66kqQOzMzT8/JZY93VQ5F6wOL49baeLx9RuEyWMrj29QLgvFEi8kzSXIDBUlwZZQTTX8VYjioRLSsjKF40O04XpRxyX7Pjg1mdtTW+U5mFhFxcC+EqIuubbpmRzzDABQ9RjI7N7T1XRrutsBOuXtBkJY7rF0p1aPhJFB49N0VQmYDoqPDoRaPADSrwMgiIBy74X+tCj4qoM6Rj7/igAIWxh3A3nEnL6NCHWXXvj6XoQRqG9YS2vz+6B68lBH9eD1x8/0mlf0KVwlQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 13 Sep 2022 14:50:55 +0000
  • Ironport-data: A9a23:xfh5JK5INpBV3DnwmtAKbwxR2vbMJdrFRiYv2zbJXl9qXhvvpoCK3Hf2+NmzPBGOoPRMvK+3Egw4zW5/0hKst7Fcx0yhoI2WSZuAqXOia4AVNskEZGj0w74dKT2LAwGZG54l6FIS7U58JRVuLLKfz6SH4CaZz6SPDOGfZKtqw15gxh3/zNLIDiuxjggI8MgTerAhRDrBm5LjXdy/ldi28dE3Xbu9Jea9ntmGP5XvGRBzOo/gGo4notYLlhw30KmXOznNODuBqT4gjlv2ehEnRVTgyC06lpGniydkZ8daOAJ224WhO2SUnabrG9ZeJED7o7r8cL5xHgBTOQftS3eubJVYRHNqQnxvbVlKtBe+sWRqcQw6uWtAWm1sk16CK5dLsN992zZ6TDNgObZ1NAwgoqyxKixXXzoRZr/A4n8OpWgARHw9di6KvKnLBs7oiTtCQO4e+UnHGFMFLayXxFXLOfVa81k54fSzOH0y64x1/A7Q8R3A+Ss+CzDCQkSzm7iaN/Wbl9y0J4sjb/Z9nBD7l5yvsCc0ZEaIjjYzlawYoDGbBDl5FClKA07O9vI5ZrewNVtC1CRW6oBqISmuPrj/gfHKBXnQke+bHq1e6xBccwqoVKJlvF9k6F5FBBu7tnV1x+05KRlbEPlfHcl9XhFX7jef2cAJtqOgj5qv9ZcDyzehsRmsuOK+Q9FrEvTWmW5tXAQqAkXkE32RRPC/XjhLULTcdOhqa5kDknMu46SFqsRocx68G0sd2UQews34lOBsq/kYI/Q7wcjrX0nBE1oTyjIxRfFsYGFtxcnk3+wnJqmrq9MStLMkVwbkLbS8vNim+dN7K9AEQWImk7U5ZN9onwMO/SscSsFeOzuQOm8SCZMy4L/vnIBWqyFhPrLZpK5wjpOoTy2tAzG6vWZXPCmHZ+jUOjbIdnzUvHW5/z1qHTw0bZHlg6PZ5vKDnAYolLtaA+o8YPhTNcoh/DknkEHJpIAINSp2KqRPfEE1wKau/pLRmLU7zr/JhQus8NvBWz5izY8sXMmzg7Swe89H/2JXIs4M2v3Y+oFmoiiLTtT40vU7GaaKokIwgkOdhwymjs2csePhxcq07YYqiy55NzTLRKrsoNrgvvWldqi/33JZyrYofrVm17QzeyN+p57KI9/KciqXLbOLzjd7Gf7BzLYWhYzGLYoObiqMfh6o69X0B0vqRR1M1AOlllgFJR1A1haTjuQUOe0DhCzlztjMy/SE/ZUkBaJEisp6BHFNmBxh6LcyNyjQGJICSWgbrpBRM87WK17I5th91qInmkTuLDviaWAlkAqeMngvOqJfz/bbcmdkU6hk8VJmzWfcfaQaiCjvS1IOf1HgpkzjsR2K5jk+CSc7wqsvZe/4fgZoDdPMcz38AZv1D5EeuKrElJtAW2NE817J3DB6p7wHmsIoX8RVjyQTZTHZYYB9B8+SZbME6FwI7Ii03hC1pCqdTrkweINlN/vC+Du8gwd7tkyyXJb9CGFuU88fHYGQOsbggabogxk/zl5NfOdzPOfEn+aDvKigMAVzY3tox4oYSorn1Yh7HYlD0/qiq/dKIOOBx1W9h4d9RRPRaXoRPcykeZ4UXKUjfvCCVYXcvudSJWiluEpWCLzZLMcVoiKGqFWpje8CRC0CYAkn0lMUP7qU0C8HFefkUhTTjEz6uye1rce+BrASIemUNBK1Rv9g2NNHi2rHtGvDLBTIh8euNzDfYSiVNE+IhvMM0gTWtw1GbK2yksFAWwjL6+cjyPiXWvCZ+Tg6k8pOOXUxA+ZsWcANEeTj5tFPoxtjtsz6NNLu4Cpraq/GWGZ088QUyLli6ZsMzLI+Wp/a5a0x8BO06jSU6Rt6ov7ejzGSKjxUe7MIbOH36xVswGPHQ56lx/D2RfFwW5YJhu9b4Y8jah/BAPfi04Q2G01ZFvp/izX6tpEeKRoIQDbepRcbwzq3reqlK8bMd/UR3b32YdCwx2oh5Ch1ak/bcetjagFU11JZL1lyCKh1wohkUMoUoCz9u8NeYIKU1bF4ZjtZFbW8Tk8qKgpZqLdBLAbMJqO1MfhYlm5CbmygYnReQgMnxHTHqo4ZrTW+yPdtmahYklXDfFXemAMlZrv1LrqxDfu8belZmNEX4lms6OO6sgF2aGL/uJQDOQgPN30RKFj5shQ2dOJ3GvQwf4UvAy+F5DFdgqnolh+nAYO0pzyRiN58cEpfnD4UH5ayxPChNu5cbJ0bLxUuRm3DfFtMjUsjgvU5HPQfSP9a3O20RM+8HFXi2WtxvydHP0Xp4oghXSeoVtttyhmFzYc6KGhcgr86R0d549TvSo3K2WNGFLWZ
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Dec 13, 2021 at 04:12:55PM +0100, Jan Beulich wrote:
> show_hvm_stack() requires interrupts to be enabled to avoids triggering
> the consistency check in check_lock() for the p2m lock. To do so in
> spurious_interrupt() requires adding reentrancy protection / handling
> there.

There's also an ASSERT(!in_irq()) in _percpu_write_lock() that will
trigger when trying to acquire the p2m lock from spurious_interrupt()
context, as p2m_lock() -> mm_write_lock() -> _mm_write_lock ->
percpu_write_lock().

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.