Re: [PATCH 08/12] Revert "xen/arm: setup: Add Xen as boot module before printing all boot modules"

[Julien Grall <julien@xxxxxxx>]

Hi,

On 26/08/2022 13:51, Carlo Nonato wrote:
> From: Luca Miccio <lucmiccio@xxxxxxxxx>
>
> This reverts commit 48fb2a9deba11ee48dde21c5c1aa93b4d4e1043b.
>
> The cache coloring support has the command line parsing as a prerequisite
> because of the color configurations passed in this way. Also, the Xen boot
> module will be placed at an address that depends on the coloring
> initialization. This commit moves the Xen boot module after the coloring
> initialization to allow the order of operations previously described to
> take place.
The commit you revert was created in order to print the position of Xen 
on the console. So while I understand your aim, you are (temporarily?) 
not printing Xen address anymore.
Therefore your commit message, should contain some words explaining why 
this is fine and how this problem will be addressed.
Cheers,

--
Julien Grall