[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: correct cppcheck-misra make rule
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 9 Sep 2022 15:16:06 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 09 Sep 2022 14:16:28 +0000
- Ironport-data: A9a23:4DHLuqCO8nFb4hVWkefolDw43h7EJoYKCyr0ZL5iHsvXIB87LLMz+jq9RysF0KIuFCQ9jkkCHt/CeD6iZW5agGHhqyaHLhRGR9peelVxHpIyJc6eOtjwBKd1URbCzPQDRHrx1H6Jld1w4m/vyXYSixIqJvIz165qrO+WzwHGuhvt6CgDh2Qqx5Ovvt7i0MZ0hE0x3O9ZBis87QW4iLpQkKHh0o1CSEharG8DdL/Ec9A5tso5FwTPJVFgG7RLZ5TLn6afdlqCo+AF53jWG3tPMtUJvNaAklQmPq+3UA5RlA1xg8hceBdaCWHZLX/gkDOQeJyLb5/utzlCObB/jhHtkLKBPONxFVcsEn435cPBL/too+94px9OvoQ6NR/r1BhySDdBZkb3eHCS1MwOAWFPuAcM8Y+xJqDnKfk5T6Q4VyNTQg6NCJ5UBsWFsAcSPYy2K5jhT232JQugJdewhl14HMngtQg9PZAnLJqecAWau7qcWdviUoK6cKHSv9TiRlaxul2zbbvbp3Leu8Bb444GiaaEHysrnpTCDihiP2ay6+RHmv0Yz69MitFoZatQEhxOgvBIbXiPEnLVaeGPQEkfDkWbvosQTpq8SNk9I4ZLhDxVUdUiku+qX0EqLSX9eVXmp2e2+NAJUEryWb9hYn56ejmOFxFZrRH23jxAMkVqoe9ggwxI/3CataZ3ImZb2Qg1QDPwXn6slIj0zePtc22izGHX86fqiCSH98DLmzoYtHg8WF6sse0wxuMjyZWIvCKNYcittNia3qQEOBmNVHTw67h+76PP5J85zpnFYEHJHGROUJlIjV6E1acXqwrrsDrWCnO2H/IBJEWqikev9zd2M2qtIsnS1NG1Iwod/8rOKlczWTrKlZxZuxqjyKusyIwczkentzQglcrkdga3HZok7uNOLZqrlC6wrjFVWWf0Pg4DPZDi/u8q4ouaT5wyEfN61Ob1/Z1u+eonFIj2HI8sS9oeDWL4BiaOpcQrhjkOz37IQY9AulXF5qI1QaAJWsV56QK96db6wHggI39UNCQI6sgUsMETG0NDvduHxaNJU3T3AB8nI9QfID/ezKJiiKXWifuXqICH0rJ5HSWaa6A5vZ8+bVE3cXf8SyIo/LG6H+PitZU6+AAHvmoO4hxiKo1Le+CNeKqw29GsV09iMF+yw7iRdszjbXoyuAP4fWAIvGrhrbNreTIIX9siMLOplh1Iontb+OL5GO8LJuVhHQD+NsavHaHaWXHJ3OroQLaRPU4aQ19zABKaE9PzHIaYkCkBmLk6hEUHJ5oFDSbkyoY/v1r8vuGoEkk9SSZe6bnIEtglZghWPL3n2CAnvGBClpSZfLSOCsPBQIyWCYYOjy+dl0E0YfQ9v3BX2c283pRVhgC0P5Z1NpV9hk3HSVg6Y1oIU1VjezZk1vnp8nmhyKpmOyRxdIEywO9oF949r7bTV21etbyEL/cYDCTGnVH/hryLh464wkGgwh0DQVcmKDMjxNBv7qzY/A4+LOyKtHf2e4K4wXEdgUbAJzaGSCSCoiA/1G+DJSwCTKyAB+pEuEMKNRIrwjEzs34cyImRUzvmLLcHAMguIUYQY4QrBeJvhLqaYQv5m+CYPZDG2Pl1dbALWvHBKO4p6DdLyg5GlcP8A3dPOG3Jrx908GtOHm/Mfr3Fz/qzZodO2WF1u0NPYm1bSXKdBYAfd+m57ZnMAvJvRFBlKTO1IDa2WjkF9jjvPzC/EPY6FNUkX4q+7JIUZMtCA6YvOdvZwS+NX/y1mtWXLmeRVM/O5P7Qdd7v79vSym9cq4MvQfTr2vrnRG8CW4yHZut6I0DAg2O+7n6jWynz88apcfqgvHizuVTkEsh1UXAiS1TOBriX6DrdaJutiEitOQl33Zu3sS/WtuNFGi/nGOZ05TQV3/4xDPNiJV/Zvk91Lhg23nv1uUvKr0Cuk0eT+KUDdf4VtyyRGYn+G7295Yr/Ovs2B7TIBYlfAOQTFF5hhMe6yYNazmaKinBK5vkjZNnQ+vKfTP0vK9Whaf44dk6Z+6aee5l4Wdi+mgwSlDB5pgd40zNVWyL2CBCxxSQBoDe22AAVyXmYVJB/ehgVj4L/gD2HgBJ1QuJc5TrlvUMujF6dPluXlCGiO4fTYOBEzw5tKgTSjINjN9N+14bKI0nJ6QNrR3A4u1rTX3btw0mk9oznKpH4bc3NYmRgI1zu/yN5rPY/JjjLM8rVc6hma9r9O52jjUn/0PRQal8MSXErcUUHbzGN0wFbSAP3gpDwKR8G+9OqpyRAHYfcG2jX3sKsUT59gkXz00NnS0KNjHU5DHSOqw3X4yh1xoQxCQG6dgsIJycrcYGEV8I6iaRXv28hFeP7hLnYp+HoSEOsb/XhTRJn8vqkdfNo3WKUXNSIsCJ19zkBnk3pJJLXRZhVNrAN2Fv7y0sy9/LR5hIXkIZOl70ob5Xo4OkvFGOLnrQYRMJNr4vYIUwmFjKdFy2E0sE19/EmHTIa6S4b6bmNLYkUyTRIOnj5EaBEJbG0VrN3qjRWMMEc3KVDO/OR8EMH3+8WhoZOFXrCi3syyD4IxsiGgM2/aV/AnRBlTuJGZuOfQmQkAmtiL4zHmpkkVQo7aKJv0+8qKRPnwOd0OAXyuEXO6w46uUL0d9jN3/Y595CXZlg9MMUcNFNlRiQRvSN9NIyuYR0H3id46tGsiYxwJg1OuN/oxoM1ehRjWIr/7xwZ7VHlETplr2EvUNEHHrqIet9/O6pMA7IMYNsUIqofPJ36FUCpMC8u4sGvM+Dzvk09R65oR9vf+oUqHfCJiz9nme7fS6DNbMY3Gg/gvuL3TFoS6UF9jeceL2JF6/Nutc2IcSnAcdgJ
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Sep 09, 2022 at 01:50:38PM +0000, Bertrand Marquis wrote:
> > On 9 Sep 2022, at 14:41, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -746,11 +746,9 @@ cppcheck-version:
> > # documentation file. Also generate a json file with the right arguments for
> > # cppcheck in json format including the list of rules to ignore.
> > #
> > -cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst
> > $(srctree)/tools/convert_misra_doc.py
> > - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $@ -j
> > $(@:.txt=.json)
> > -
> > -# convert_misra_doc is generating both files.
> > -cppcheck-misra.json: cppcheck-misra.txt
> > +.PRECIOUS: %-misra.json
> > +%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst
> > $(srctree)/tools/convert_misra_doc.py
> > + $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o
> > $*-misra.txt -j $*-misra.json
>
> As far as I know, this is not saying to make that both files are generated by
> this rule,
> but that this rule can generate both files so nothing is telling make here
> that calling
> it once is enough I think.
A comment could be added, the same one as the one used for syncconfig:
# This exploits the 'multi-target pattern rule' trick.
# convert_misra_doc.py should be executed only once to make all the targets.
Cheers,
--
Anthony PERARD
|
