[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/gnttab: fix gnttab_acquire_resource()
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 9 Sep 2022 12:34:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W522B65Ql8ge1yXQa0g03EnCK5GQLmyF2y9BK1asyac=; b=YVLe5YNATbbgE5tzvkH4sJINiS7bkmbzrR5Or13iCyDYI2VhdahqTxTPCkmWkOVWgYNbuWZKHE4h1HnwMJDFlrF1JDDVtuvo+y0NIlKzACCCmVqnUakMCVpSJFvgsEhLK++94Bw0vfXkbINxLfn+1dtGeHp1GhYViY+xvsigg1/qDJJRxq62yiX8fNS9zMyr5gqYaLmrqDIMR0/+bmgyjxGITjICuEnTok/LoA448ug5i1+uGko5vil/cLFM+I5DA7y1v9QAtlV2GkDBA6piof6sgAhHjXnr8sP/NHlQUl7dHtqyVFIBj7Zx5u5CngZJQd0m/orl+PycD0d2JZcpUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eIGUGHXKfKxT12bzTdxcNL7AfO23OcwG3qWqbAKPw20lktgKM11Ac4gzJu5IvqD5uIwdB7jDVihkP/ksdbCGiKiYf69GOw+yyutfZiFxXRMj046aUZ/THpMXVSHUNwIjpBbyQrNDYYzbn3zv3EF844/k1EdlwtcFT3OrDUVPO8YVKzYcvNBqOzX9//n2j7NjnPV7Vc/y/SqbVJHzK/XxpACxTZbGZDf5RVdo2EvtsWyJzya+W4XMg2kv+FObj1eLIEJd7MxBJ2kWslU5yZoRcCHq6b7Y5TEUcmm/x5SiTGi/yiHwUzhdvS28dgHZUdhTLngV6WJMf9YCVoeRnyf+iQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry.Wang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 09 Sep 2022 10:35:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.09.2022 12:24, Juergen Gross wrote:
> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> warning") was wrong, as vaddrs can legitimately be NULL in case
> XENMEM_resource_grant_table_id_status was specified for a grant table
> v1. This would result in crashes in debug builds due to
> ASSERT_UNREACHABLE() triggering.
>
> Check vaddrs only to be NULL in the rc == 0 case.
>
> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> warning")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Might be considered for backporting
Sure.
Jan
|
