[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 8 Sep 2022 14:49:16 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 08 Sep 2022 13:50:17 +0000
- Ironport-data: A9a23:/iCwv6CqPVwwWhVW/2jkw5YqxClBgxIJ4kV8jS/XYbTApDJ03zVRz mBJWG7TPPzYYmfxedB1OY2y9UIFvMeBx9A2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpFs/Lb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW0fl3dplNQYSB6kJ1tl6C1N27 aA7BS9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDmJllwggeWF3Nz9RP2ABphvpn+ku 2/+wE6gBDcjMeOY8G/Qmp6rrrCWxn6qMG4IL5W/8vNpm0GC3Ww7BxgfVF/9qv684ma7WtFSb UwT/i8jtoA29UqiVN67WAe3yFaBtwIcWtdNVfU96RuMx7D85wefD3IDCDVGbbQOttIyRDEs/ k+EmZXuHzMHmL+aU3WG7Z+PsCi/fyMSKAcqeissXQYDpd75r+kbkBPJRdtlDOi6k9zpBTbs6 zSLqiEkgPMUl8Fj/7W2+xXLjiyhorDNTxUp/UPHU2Tj6Rl2DKa7Zpal8lid7utFJZyxSliHt WID3c+E44gmFo2AmiWLR6MWALij6vKBMTvdqU5uG5gn53Km/HvLVYlU7SE4LkpvNMsJUTvoZ kbJvkVW/pA7FGC2d6ZrZJn0B8k05a/4UNDkTezPKN5PZJFrc0mA5i4GWKKL9zmzyg52y/h5Y MrFN5b3ZZoHNUh55Aa/WcgW6PgP/AQv6VzeT6LD10iE/KXLMRZ5Vow53EuygvERtf3a+luOq o0DaKNm2D0EDrSgP3C/HZo7aAlTcCNlXc2eR9l/LLbrH+ZwJI025xY9K5sFcpctoalan/ygE pqVCh4BkwqXaZEqxGy3hpFfhFDHB8wXQYoTZ3BEALpR8yFLjXyTxKkebYArWrIs6fZuy/V5J 9FcJZvaX6sSFWScp21DBXUYkGCFXE3y7T9iwgL/OGRvF3Keb1ehFiDYkvvHq3BVU3vfWToWq Ly8zALLKac+q/BZJJ+PMJqSI6aZ5yd1dBRaAxSVebG+uSzErOBXFsAGpqVsepxdck+emGPyO sT/KU5wmNQharQdqLHh7Z1oZa/yeweiNiK2x1Xm0Is=
- Ironport-hdrordr: A9a23:Yuzwb6wn3KrZfJ62Hz3pKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Sep 07, 2022 at 06:02:24PM +0530, Viresh Kumar wrote:
> Hi Anthony,
>
> Thanks a lot for the in-depth review, it is really helpful.
>
> I don't have much knowledge of the Xen code and wanted this code for I2C and
> GPIO to be tested on Xen for the work we are doing around hypervisor agnostic
> backends [1].
>
> I started looking for a simple device's implementation and began by (blindly)
> copying code from Keyboard device and so much of wasted code in here, which
> isn't really required.
>
> On 06-09-22, 17:15, Anthony PERARD wrote:
> > On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote:
> > > An example of domain configuration for Virtio I2c:
> > > i2c = [ "" ]
> >
> > Is this doing something meaningful (with the whole series applied)?
>
> If I am not wrong, this is required by parse_i2c_list()'s implementation.
> Without this I don't get the I2C device populated in the guest.
Sorry, I should have added more context to may question. In my mind, I2C
is just a communication protocol between a device and a CPU, like USB or
PCI. So to me there is missing information about which device or kind of
device to present to a guest in this example. For example, for PCI we
give a path to the device (via bdf=), and for USB it can be a kind of
device to emulate or select a device based on the path to it (bus,
addr).
Cheers,
--
Anthony PERARD
|
