[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 8 Sep 2022 08:10:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XEIQJaQYbMvzCnrPv2PapYeeNIVdjAbWOsuFpT9auG4=; b=CCZnhpWOac3SpLIksTSACDQtXFfzx5eDeY0atBwAQ58KJVBt0vYcQmgB24OgV6SWzHKdcMPFjOPSzAiyGsSgsqmgPSrxIupLwzN4Y4tfnEPZHZnZA47Punmmyq3AczkLnpnmOMEvOX2v7Rd7au04HUR+XfcmWfzSbfdyXn1KS1glkk5hJ1bew09g4USaCVphrUAmeaNHbLMyK+EJyb642mtL85AbuAEcw0LIkx7LpNGyp2/+BlRa4wGLwtdvEvg7EmYnjI7XOy+q9ytUXLdlsdhc5LiRppWPrFEwsUgmf0N6A+crXOoL00GwRZyrJ+6aOspdd26rO29WFwlDSmfALQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JC5TB9uodexcVn19jl0aIqpuCF5L+ccaLnCIJVsW8/YUSCYd1lBAnqj/mMlXHtI4320TsyFANsOYzI1a5CA04BVXaIOdmtSiv432wrBHQkm+AirPKXC2GcgyTdVPCTRsnWbTZCjwClYwDyeCql0HY+EiA1jch4SVwahGbawliCEIXJhrM9aDQYL4A6P7JOFD09vMyZm04wnrfNlM8FzCnu42EKEI6pAzJj77ofWEJe94b3COxC4R+tpvsAUv647TwzCuFCgEOgWgnAB6BBFOzJ9pFoAJ6AJb/MylFPRuQa2oz6+Dwi1xzDzw5R1g34qc2spSNKihYuTsbhha1DDcsQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Sep 2022 06:10:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.09.2022 16:33, Julien Grall wrote:
> On 25/08/2022 08:17, Jan Beulich wrote:
>> I haven't been able to find evidence of "-nopie" ever having been a
>> supported compiler option. The correct spelling is "-no-pie".
>> Furthermore like "-pie" this is an option which is solely passed to the
>> linker. The compiler only recognizes "-fpie" / "-fPIE" / "-fno-pie", and
>> it doesn't infer these options from "-pie" / "-no-pie".
>
> OOI, how did you find out this issue?
By reviewing Andrew's "x86/hvmloader: Don't build as PIC/PIE".
>> Add the compiler recognized form, but for the possible case of the
>> variable also being used somewhere for linking keep the linker option as
>> well (with corrected spelling).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
Jan
|
