[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory
On 07/09/2022 15:04, Julien Grall wrote: Hi Henry, On 07/09/2022 14:49, Henry Wang wrote:-----Original Message----- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>But in any case we should only add one pair here for sure, as you saytheI agree. The only drawback is the need to modify the already introducedonly implication is to add a couple of 0 in the worst case.propertiesto be coherent.Agree, someone will need to do a pass on the whole doc which might beeasier with all things in.Well, not only docs. If we decide to use a single pair of #address-cells and#size-cells, thenwe need to modify the code that expects different properties e.g.xen,static-mem-{address/size}-cells. Right I forgot that some parts are already in. So we will need an extra patch to handle those.I think I've addressed all comments from Julien regarding my series,If it is not too late for you would you be able to resend your series without the 'address-cells'/'size-cells' change? This will give me the opportunity to have an other review today.so I think I've got some bandwidth to do the clean-up patch tomorrow after the agreement, unless someone would like to do it himself?Renaming "xen,static-mem-..." is a bit tricky because they have been defined in Xen 4.16.I couldn't find any support statement specific to the static memory feature. So it would technically fall under the "dom0less" section which is security supported.That said, I don't think we can consider that the static memory feature is even supported because, until yesterday, the code wasn't properly handling request to balloon in/out. So I would view this is a tech preview (Could someone send a patch to clarify SUPPORT.MD)? Ah. I was using the 4.16 branch. There is a patch for 4.17 to confirm this is tech preview. I think we should consider to backport it. Stefano can you add it in your backport list? Cheers, -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |