[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Add macro for version number string
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Sep 2022 14:34:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fiHQ9mFULkwOLRK7OMpRZAgpherdOO2XDetbhouZLnY=; b=JCeLh83EsCKq5Nb+sGpjSsRo/DSWyHEDmgbxbud3yXWBJDyQvxK/iiGKgPJSUDyVwDYvN6VM1lu2rxpwxs6LG5p8kMJ7KeRbqqSFEg/t233BGlHpLvlVQX+T7pOY2YwSCumFufgaWElHB4nOQkB//En3BwcnaV0oQrpET2onTTvCmEzYsS2rreUfVLIgeF8DrXWsQXIHdV66S++m9isodWVCOby5IvDLS/5bP483QfbQdV1IOlcNeEpoGczH5BHceTFNY9EIDygKdUlinOwE1AunDJemYYOwjlMVkWUZDbBnL67vn/rUWQSa3oQKghijlT7LIrbZjKRPhXBSHFM2RA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLCe7habJrb8QdXj8N6HSUU9MLr7uUlRzeXY+Dyx8pNWhw1svqtoMvnogTsXAlpfdvYhThUT3KL8FJLAwQ1GfiUSQA3nyc9v4GYUTAQ0K014kCiZIYx2YznuspnSq3QK6xW2gVzYwxwn0XVdn0Egu1ZsYpWBbWSBqO9a3Cr7Cry5DnHnWsQ42ax5lZdZAKe6xpdaRVcvXtmOKSZYo0U2M+/ULSR3+uCKH+c4A6254LE8rOqVMi/zrO7B2dYXJu7HsRDB1qMj2BLFHtDNRS16aTF9EdQPLOlagztLrfeHqF03Tu2mzWaM7qoFRFVZv5RlW27v5JhijDk6L2grss6x2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 12:34:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.09.2022 14:20, Bertrand Marquis wrote:
> Hi Leo,
>
> Thanks a lot for the quick handling here.
>
>> On 7 Sep 2022, at 13:04, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
>>
>> On Arm64 Linux kernel prints log for Xen version number:
>>
>> Xen XEN_VERSION.XEN_SUBVERSION support found
>>
>> The header file "xen/compile.h" is missed so that XEN_VERSION and
>> XEN_SUBVERSION are not defined, __stringify() wrongly converts them as
>> strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION".
>>
>> This patch introduces a string macro XEN_VERSION_STRING, we can directly
>> use it as version number string, as a result it drops to use of
>> __stringify() to make the code more readable.
>>
>> The change has been tested on Ampere AVA Arm64 platform.
>>
>> Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c")
>> Suggested-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Regarding the change suggested by Jan to add spaces, I think it is a
> good idea so if the commiter agrees to do on it on commit please do,
> otherwise we can keep this as is.
If I end up committing this, I'd be happy to add the blanks, and therefore
I'm inclined to say no need for a re-send.
Jan
|
