[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 7 Sep 2022 11:09:58 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=a8uBENGsNJRcxSfGalxG7pzlJcFV0hHrIPWl6Mg7LfToYLuGqZlJFr1kcrBw3nFw9oPa5d2Wl5pulZtFYMH7yhChIRY5N8tQW5PwtS3nGtWcD2MShHw86wexp2p5P/yHAbtsoX7j4hw6Y3s6/VMS+mCd+7fhFbcTPMumA8dR/ZZAxUTJ7c/GuI0/FU39ElTc9g6FEzy3n/x43e8M6rUE7GYM0FSXdJ9HNGSvKYUNwPueUmaOKS79YrO6MzzOS+JFT4IgZod3r/sce0Z7fvRz2gBF0/tg6B7CtkrBVlDoM2WcP9NDPPwmiGpIxcZMB7M+YDNk5xuStZfSB7bZvyyA+Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8H5pn8f1VdqPGSdfqwttHldUYLpUMX49Oec+NuKpoKs=; b=PAGovvV3e/VFFf++Y9S94PJ2JdCmGmxAhiGiJ/zJnVsgUMsnfklLhwxvpuIHP0q6eyDVp9Km5rbZEzBINa5yEg9kyNRA1XNYTyNSw71rU8RwI1LGwx1tsMxG95++yeMgLzwQeIfOQ4tA5sWTBbGcwCHi+GjiD7gyJEW1l9GSpe7ZyZid5YaEursv0WozBXOGukzxo/R4Rotjn7vkLi/yHtihPH9BHZxR+rsK8WOuuM+aMmvYhZO23YO1SDIGHa2dt5zBxg5rT8RJYjN2fZnCq0QW9WjKeVA+TEyDmAHAIcDdCLbidWZi6q1pEUO2zwIx9HNehvr4/PxxfJzPvHVywg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y2nBgw2JDrk5kvJ6nSBK54MXzdN6NW6fJ8ShMWEpvsnj1h7n9rr0J3izTu6kyabSg9wmnDVypCaIlLqJdPQtUfV3fw0zVse5sELx0lsrCo+wdYx4ZvpPXC54vMPkC+1LZ1MMr5YpwtcFIwN+k9x21rm5N6gF02FLHDLYTDhMJ1YAJwFvoSfqp5kmHopBRAecJ4cOO5r5pWwpgFatiD88qSipv9mlGLyrKDgorL6k4aoolkV2yKeDnMeWTtVcHNDlKm7fUGnDXgzL0KefB+/7hrIhDmj8mOvA7l+XUphW/Wvdm0UxxLNd0/HXflMR6/j+SYc0kTeOtaDrRm5BuAa8hQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXw5vsWrOTOXcF1u/O/mt2tEzFVatxCnMoJ5m8Z6VOIXaJd+cuWICBmYs/rlj2ks+qHUxk/pJlSPQstyOT+GE646xvGeeu51CCsTtc9S+qGD+2HbmlZbiYq1M6oY2CkTFVdCYvOTueYJLk0fuJEK4uiLL6t3CAaKAgwwcOA19TaieitTdHMY+ikx0Phy8UT4OTusbA1BREtbvFjlHotAffzTUjW8u66Tp2z9QmSETQoiJSmF2NwlKKAvA2N/Up6i/27FZVUB8dnmIZCMxLrGyMHCIvOSw3UX3kGx0F5teWKP0N5h1Vax7AtGQUgx0zjfqtosFazMPttNBMdFzrmCNg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 11:10:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwpULGFLWtgCBlkSkZYDaahDS7q3TxKQAgAAEM/CAAAPgAIAAAFfA
- Thread-topic: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> >>> @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned
> >> long base_mfn,
> >>
> >> I think the function also want to be renamed to match the code below.
> >
> > Hmmm, renaming the name to "setup_directmap_mappings" would
> > somehow lead me to think of we are getting rid of the name "xenheap"
> > completely in the code, which seems a little bit scary to me...
> >
> > But I just checked there is a comment
> > "/* Set up the xenheap: up to 1GB of contiguous, always-mapped
> memory."
> > above the function and the declaration so I guess we are fine?
>
> We are not getting rid of "xenheap". In fact the common code will
> continue to use the concept.
Ack.
>
> What we make clear is this function is not only here to map the xenheap
> but other memory (e.g. static domain memory on arm64).
In that case I think the comment in function declaration (attached below)
```
/* Set up the xenheap: up to 1GB of contiguous, always-mapped memory.
* Base must be 32MB aligned and size a multiple of 32MB. */
extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long
nr_mfns);
```
would also need changes, as I think it only refers to the Arm32.
How about
/*
* For Arm32, set up the xenheap: up to 1GB of contiguous,
* always-mapped memory. Base must be 32MB aligned and size
* a multiple of 32MB.
* For Arm64, set up the directmap area of memory.
*/
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
