Re: [PATCH v3 4/4] xen/arm: Handle static heap pages in boot and heap allocator

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 07/09/2022 09:36, Henry Wang wrote:
> This commit firstly adds a bool field `static_heap` to bootinfo.
> This newly introduced field is set at the device tree parsing time
> if the static heap ranges are defined in the device tree chosen
> node.
>
> For Arm32, In `setup_mm`, if the static heap is enabled, we use the
> static heap region for both domheap and xenheap allocation. Note
> that the xenheap on Arm32 should be always contiguous, so also add
> a helper fit_xenheap_in_static_heap() for Arm32 to find the required
> xenheap in the static heap regions.
>
> For Arm64, In `setup_mm`, if the static heap is enabled and used,
> we make sure that only these static heap pages are added to the boot
> allocator. These static heap pages in the boot allocator are
> added to the heap allocator at `end_boot_allocator()`.
>
> If the static heap is disabled, we stick to current page allocation
> strategy at boot time.
>
> Also, take the chance to correct a "double not" print in Arm32
> `setup_mm()` and replace the open-coding address ~0 by INVALID_PADDR.
>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall