[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 1/9] xen/arm: introduce static shared memory
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Wed, 7 Sep 2022 01:51:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=RwcNvGhyKq7bq6LPElydsVERykJWy5NOnxwUW6SisElHKBkjgLMh5xPeKS6UUXjImuO7oqN+3ouKppBIK7ukDmyguzo8PVwW1To6iTonv3p9vz71lk5juyY+EChYGloLqmyu9/R0bEtKOZIarhdE9txQHMn0Bkw76ExTSSRz2mzVvDCAcUqA0v0t1NwwBvWKmouw+Ng77w/M369JaLZ8rso5dW4adfJWtX30rFdUtMtBShNE6YY8/ERDiKUp34Cl0EgxHBJ/SYE/Slg9brcKub95o04PQgGdrS9B25q+24/lW7iXlxmviIpoamtnRkE5YS0q+tP9Ebl7Wr5ePqEmGg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HE9saJQTobUGhxaXnO3gVZQOTovetEBZrp3nW3mrBo=; b=TC2rrQhEL49YPxFwWc61uSzu/VyUlB9j/fj9w9T+j0flk3mXHKhMoiOMMXd373gv1f+qZa9s70gJm0Z629u/F/pVNTqJAhNZ2ssgAG7qNMfrXaBJrr1B571MnILs4UI4/7o+uri5d+SkOI/bT864vdQ12Gji6MBlswEs1XE7wmsYOS1CGC3SAtIbeeuttadWRdMY9IBVYiR9AtbaOZVxONSGxBREMorrZm/91Nb14s+kXajdktzPkIA+hpyEZXm/nIC9yVytRRHc40y4XJLFb4zxDeIBgsn+bl6ks1aVlL3duAWudBw8/qJ/bBBKfi/oQE+1d2DtjSKTbkWOK8v+Ew==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lhqrgkjGTtYacmPQGIBqtiHQ919KU/0JyGGsLrT53PKKg5pK9qa174p0WsQjDgLwAgXOOhVFY6SvJG+hmkCvaPk3e2lWS2DITs00cuAE78M5cAabTMNqYUHDU8QekiS0nFIJpMO2WclUTeaqPmvNHWNoMlOr0oRtyuH3gW6q7jyTThegzKzaifdi59axnogt6v+eoG4pZulAgiiCWmc6xe4QbJLuunEsTmUZTBdIyugICV0eUZW9TgZN4wIZGWWYDRQrctBcmMapDpSMukRY2bZDYa8rZs39XvVkmgPiBgb8dh3jrZkgnOsw6fxa63ojh/uG9o2pyFcybvDorctlgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfZC/KJI0XiAk3M0JW+2aVH6TH+L9tn8a1lA/jTytwQhWVPozRmEH0Aw1GFtIslBKbUu2Z5GlE0OMS8m5bYrnjjZSWhpQcMbzDf2GnjRqzgZMm57Yn0V0H5kOCwIAV+qwIq4jXw383izcCHHs0ltjB9q+R9LcNmvutOPTBx5U4hoC0EwbtW8CFzE7+Zci6bMvalAd9UVi54/ImgbYE7V1UDHy9AVwF3IiHL0NDs0c9xVtgJL3FOjfvuMamSZRTPLS2H5+Qjma0vS/q+/dlHsyI5LUdlCN8M6PTJ6C9nqtVt5Wn40Fh55jYQnxw4Br2cY+xAZ8U4unIiWWvF8y2+Apg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 01:52:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwc8YBf6RzKF49UaCIf2FqNDCyq3SsZmAgACDQLA=
- Thread-topic: [PATCH v7 1/9] xen/arm: introduce static shared memory
Hi Julien
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Wednesday, September 7, 2022 2:01 AM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Henry Wang
> <Henry.Wang@xxxxxxx>
> Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory
>
> Hi Penny,
>
> On 06/09/2022 09:59, Penny Zheng wrote:
> > static int __init early_scan_node(const void *fdt,
> > int node, const char *name, int depth,
> > u32 address_cells, u32 size_cells,
> > @@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt,
> > process_chosen_node(fdt, node, name, address_cells, size_cells);
> > else if ( depth == 2 && device_tree_node_compatible(fdt, node,
> "xen,domain") )
> > rc = process_domain_node(fdt, node, name, address_cells,
> > size_cells);
> > + else if ( depth <= 3 && device_tree_node_compatible(fdt, node,
> "xen,domain-shared-memory-v1") )
> > + rc = process_shm_node(fdt, node, address_cells, size_cells);
> >
> > if ( rc < 0 )
> > printk("fdt: node `%s': parsing failed\n", name); diff --git
> > a/xen/arch/arm/include/asm/setup.h
> b/xen/arch/arm/include/asm/setup.h
> > index 5815ccf8c5..995eee1d09 100644
> > --- a/xen/arch/arm/include/asm/setup.h
> > +++ b/xen/arch/arm/include/asm/setup.h
> > @@ -23,10 +23,17 @@ typedef enum {
> > } bootmodule_kind;
> >
> >
> > +/* Indicates the maximum number of characters(\0 included) for shm_id
> > +*/ #define MAX_SHM_ID_LENGTH 16
> > +
> > struct membank {
> > paddr_t start;
> > paddr_t size;
> > bool xen_domain; /* whether the memory bank is bound to a Xen
> > domain. */
> > +#ifdef CONFIG_STATIC_SHM
> > + char shm_id[MAX_SHM_ID_LENGTH];
> > + unsigned int nr_shm_borrowers;
> > +#endif
>
> I forgot to mention that this will clash with Henry's series [1]. As both
> series
> are meant for 4.17, please coordinate to decide which series should be
> merged first (this is to avoid last minute clash on Friday).
>
I'll push v8 ASAP when henry's commits get committed~~~~
> Cheers,
>
> [1]
> https://lore.kernel.org/xen-devel/20220905072635.16294-1-
> Henry.Wang@xxxxxxx/
>
> --
> Julien Grall
|
