[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: acpi: Include header file for version number


  • To: "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 6 Sep 2022 13:09:28 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=SskBLFsoI8ipThe31t2mK0U1Pr72CEyMD8PJ79ch5oi1qg9qns0W9vfEjJT4cNQZNaDucxlgY3c62GDTm6B4axPDGHFHOPsHdkiYSYgSJXecXuT5s+jTf+GIcKVHXgtPiepngWATK8vN1aZIyBdMPRlxY1G2KfN9GJvfmR98TLm8qBWfg588M/p2bglWM0NP2twfRK6LJI/sMsHOpTac/qhuWqpje+iVEix22k6mxjZNbw5gilYS8ekbfgamO5Lck+rhslRtLA/KiutZ0ngw5FjwfGRWkX0SP9Hlw+gQqIo2kwiEJY7+ZGg70LH51tmSZKSPn4hseB4l/MTVeSDvAw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2lfvMOkncCIuRb+EZwQay3iR+IhRohamSnzjyZQXLQ=; b=bfgGGOoQ2/gzdiRBMc2pU/8Kr5IQWbH35yUHSpbY34cwK8NIX22sQPrLfkY2UI3Fg1EzR03SMOKbHleKlUBl+qbtPUaLxEwVqD7UWApAB5dzU2RHlzIRfoiE3ZYgO0WwfZOrh42GIFKv2fHIOSF8VqMirV4Zda1jYkNIVcKDPe3szyz+Xi3kRdseHilP5sjdCBruDHtyhN9pfQbDcV88UhOrGPJBx2o2xufpGaUZQqhoNGWth7LK4fCXpbAaHpRnaAMjhRvZVGRx4N1ViBcNjoTs8uAttcjmed49d8stdItbJcqQ5inrWth9P1/BtKUJCsWaytibFJ4jmxyqDoOptw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XvTnAT7UeuHEgnwLxFKjkJwYC5OKf/sSInD73MpC+aKvkx9H7NYkkA7nZIhl5b7l61ft8P58rplFXj1EDKLyqDuwUaVsqqFnIQ5igZMYjPQipV24ZjN2q88WU+BxQ8rUspCpJJVdLBCXe2ixNSgoJdcVKq9GyjxcvYUGD+PQ+4JGF/eFNSKej/509c/dZJodgKPcloosfflT79TWr1Mz4g+ZbpWGJhHg7GYTEU6Yrj96vCPXXiQeE4bIGBfkqKwjDd9NWx3K0v0bNj7XThu++oAQKqOMxvhiWfwEwqZWPSUxKW/CSjFTHsg+9NX9qfYCLoOR06GLMz92mon6MFF1vA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Omfpsp6htz0t58upEcgko9eb/1CRGgF/9FpGnkmc3v9Pgihkkm4lLYWlRKEPyBsEpyY/GjD/pnXz4rseA5IPk2Rxe8MIi+nlA5SYZUIFYhXSRK1XZv5Zns5p11xbPKbXAI1VRvc6hb5zYOISS1wLKcqeT04EfqlVc1jIYYOui049/HCZ/cuJJPVpdsdMLQDqpLTNd4TdcHiHtqmlxtEYjeeRWOCYBHCtsATkxFR/qzqaChuvTyEZl02gLOKhJx4GBkk4bSLd+hxZ0Mivdz74dvSBIH1l2N/DO5zHa45mpXHparhVEajMg+a+U0RPsIID9dG7+UiML+Rcq+6KhoosdQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 06 Sep 2022 21:50:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3SYAEA
  • Thread-topic: [PATCH] xen/arm: acpi: Include header file for version number

Hi Leo,

> On 6 Sep 2022, at 12:31, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
> 
> On Arm64 Linux kernel prints log for Xen version number:
> 
>  [    0.000000] Xen XEN_VERSION.XEN_SUBVERSION support found
> 
> Because the header file "xen/compile.h" is missed, XEN_VERSION and
> XEN_SUBVERSION are not defined, thus compiler directly uses the
> string "XEN_VERSION" and "XEN_SUBVERSION" in the compatible string.
> 
> This patch includes the header "xen/compile.h" which defines macros for
> XEN_VERSION and XEN_SUBVERSION, thus Xen can pass the version number via
> hypervisor node.
> 
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>

Very nice finding and side effect from stringify.

Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> xen/arch/arm/acpi/domain_build.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/acpi/domain_build.c 
> b/xen/arch/arm/acpi/domain_build.c
> index bbdc90f92c..2649e11fd4 100644
> --- a/xen/arch/arm/acpi/domain_build.c
> +++ b/xen/arch/arm/acpi/domain_build.c
> @@ -9,6 +9,7 @@
>  * GNU General Public License for more details.
>  */
> 
> +#include <xen/compile.h>
> #include <xen/mm.h>
> #include <xen/sched.h>
> #include <xen/acpi.h>
> -- 
> 2.34.1
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.