[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 6 Sep 2022 01:04:06 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=M+x/hphgT3V88UrKH4llwUU+o7VbkV2e69liF4VeH7/L3yg0LvFSa2Fb8fNvKxwIoPjet76qX5tIvv+xJUv9RnqJvYoEkozLYquWBiC2RM9Zo9i9s9Kg4UoL9bjN1AdYsDArciSKEX24581uQn58aeRrJjPiPXKycw2JFXRXNSISD5vQiXjnfYcl3Nw7WaMXrI98FbXx6E3hBAbQRaOkyb6F0MRBGwwv8VkqNeNnbj/2T+9CoWn4ejTat4pZkfPS4ryudpD8gBAm81V2CAzbFcBZjM6hNqgULudid9kftVsg9nACQMlfzAGeMmYLfVhZKSjeDxKCjDmGBCAK/8FEZw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vww4n9Oj/OmLWXmWO6p4e6ZT2aAz3ONu39QJ6TLyNnc=; b=Ij6zJryiShGuzzizS7WyBJ0ksknOT5Clzv8Xeu9jL/K0I0F+ug8P5yxam3PUob29SW6NoYc+lXY8n0EgXbWKoQxPsL/xUn7QD28mxiKpvbDMJoHCjjo3T/ayenCzMuDX3BpJl+mY1uLjo+paVTeEiyg0fEkhjuCljVDXlgkzTRnm+yNnelcZlvfs61O9n4p/qQ0yvSfnQPRw8smVUCX4MDLRaeOLZUnQQ7tQzfDzvXnE0Exago4ohPP2mnUdpX4aJMcrswheLlo3lYnv8OsEMCjUM3Xj+yPO8Z/72Qn1/Q5CjkkwGnlrh/v0VqOPvxeuzuqACbCLhZbAjZcN51NV8g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cRbayMubTXxgkDD4uRU6D82LCVGKDxhiiTUEkVA+G+VhWrij3rWH9jAiy1jRucZevJ2m6pMarPfernKH/9NXhMuc5yQlnxRg+uFPzHKXu5IhNMrZH71GfrVxDxAd8x+c1K8zyNHfHQADvo+MJX8r8vRwdxZht1wEPiaYNg+pFWpOSdADTuEoai2YtFjYJp7P2yELvN/9ZlvWJOCi7AZvrfF0c2nZ0cGu+K/tYMBmZ7MCdUoekhT2i1QH3cIzv/smTYJXONqtroCbvd+eqlJW1WpKrSD9iASFmG6i/C6/rt6+G5FktNF5IsKWDpEqBHAsLrojIViNyzloHLFsxt3J9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kt950srEvHf3oBdQzApxxnWMNtCrAf6vepKjN6G7Mw50/OrvvtnHY4fUt5stEzrq8Rm+AwxxrBkr8KzuyrynYUP3FVEOknmXTszofdZHMrEzzQTjROsfxKLcde1rKDyRAkAfcELNyzE+oqhJkqBz7M9w3t7qem7UYNUBsdbSWE9FMbNb520tGXGfZFnXdIm6LPW55rFtyj3RhcvGvDZ4TGQuX9yfzTln4bAQYGg5kl4YivAIG0Jvs9DWusETfFquAmUpols6at4M8b2mGxZfDBKwe+QMTTXTRVurBb7FA7UTMd6lIq5q+Bc1MjYinAVEfDbfjxu6FTnFsurW9aTJcw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Tue, 06 Sep 2022 01:04:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3RcOeAgAAmEqA=
- Thread-topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
Hi Stefano,
> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
>
> On Mon, 5 Sep 2022, Henry Wang wrote:
> > This commit introduces the reserved heap memory, which is parts of RAM
> > reserved in the beginning of the boot time for heap.
> >
> > Firstly, since a new type of memory bank is needed for marking the
> > memory bank solely as the heap, this commit defines `enum
> membank_type`
> > and use this enum in function device_tree_get_meminfo(). Changes of
> > code are done accordingly following the introduction of this enum.
> >
> > Also, this commit introduces the logic to parse the reserved heap
> > configuration in device tree by reusing the device tree entry definition
> > of the static memory allocation feature. If the memory bank is reserved
> > as heap through `xen,static-heap` property in device tree `chosen` node,
> > the memory will be marked as heap type.
> >
> > A documentation section is added, describing the definition of reserved
> > heap memory and the method of enabling the reserved heap memory
> through
> > device tree at boot time.
> >
> > Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>
> I think the device tree interface is good and you can consider it acked
> by me. I'll let you follow up on the other comments by others on the
> code changes.
Thanks, I will fix the comments from Michal and Julien.
Kind regards,
Henry
|
