[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Fri, 2 Sep 2022 15:54:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=R+JOCLkVAeT5+QM5veE9y+4nUYa3X29Zi0sXGa9S7/acktVMtRrAF6fQrIddiUifmxiOuzqJFUMcAJKvhjhayqWLliYMAHP9VY8ywQeX4kjNZsszAtrgr/GRmFSK+mIFPUS/yO5UlxXtgapO2FIy7YjSWqon8jPlpThoj6ip64BHPrbPsykzfCNGfjiZqBxgwC6go1hx/uCfIAb/E0UZRC5hWbxirFCKKxLqCb2ilV9QiLBBzV5ynD2NyI3mtLbf44cVLITUHplElSw+JlupXcjNljQhYhT8D5d+YJtcZv0CxUx54Sk51byYVxPq4fNMIJ7pouLXSW82sBXlwwa1kQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yTsAaJE72t/O9Bq6IlWOFuulUXKMbzN0cp7XPNDqjYM=; b=Mdeoi2ifzntYYY+909jtZuhYRHfuzJFZJA4lFyRBfvHsxVKzOTRHrZG2PofXN9/I+0zhp1Gw8h9EAyRIbWm/1pxbd3BhkBbES6fhPnAqOOGDDHucg7h2E0z8JCeL2KnXKpTk1nfzR1GrVpae6vTCN+d8NMXRXAt0QjyEvky1Urd+OeponIn0G+i7Hq+k19I5uBJJJTnCa+Z918imSShuJF2km6XCerV/0SKAz1Tpcxndshu9+hZCB2DD2jUpUAgQnVrEJSFcO5cdtsY0l1PmgexHGA1T8AEVvFGfsvRceMbC9uuEpIkYbM/zJg48Cm/zkDz8qmivqJtue/AwB/SMlg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=S6NIC2IroUJP8de6BYtVsnbSuIaVHWfgWoQ8fnB4mx8enrpaXuIs61xpO0QT8wpd5JObiENOXfVU9OQ8ILOf8oVniWoD3uC7Qy4soNUPl4i6bQR0ktI9ta++Lii1RLKIxru8uRl9njb1R1ol/5cmR+Q82qziO0iZiR2CnCby9ZPCpghhsYFsNdJLOgOB8iZTHZQkGKhevsy5NcwQth9WgASA0aS/urk4glqjdQGvHYfLks0uyxGg0cgvpIsPnN006H/0NYnUkQt+b9NylgPODfq8uNDw3kw1rmU36icmvqmgmtG9TQv6TZQEboEyUJCYQsD/C7ime57MEPW9xZ+gFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGipvzuzPO2Ma96Xxyf3e3EcbtbCpjTBw/yYFzLC9JsFDNEMo2iuEYIpa/6Fu0AnxLhsLgm+Ft1WZkahmga+EDWngUoyX1eW8bXItnDPQgiD3d67q53ETDvHCiC04ieI1N4jMZfkl+wGXXWTZUhLe8ec2ZU+4tBy0wGtyxUlMyCrrP6w+BQI0BuiIvW0e6KYLJ65d8y990oqBMa2ajnLFBoPDyDK8HhDwDI3N5DNHFn6XSeKWK2XLG7IQfoEJnLWqWEYuthDGjSyhf9pNubp8sIMSmuI+Tch+qVHBfLgSlMSuqyEmNpZx+J6E42IITOObHxHpaUPz+1ROZOG+xGXwg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 02 Sep 2022 15:55:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6A
- Thread-topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value
Hi Julien,
> On 2 Sep 2022, at 4:05 pm, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 02/09/2022 15:51, Bertrand Marquis wrote:
>>> On 1 Sep 2022, at 19:15, Julien Grall <julien@xxxxxxx> wrote:
>>> AFAIU, it is not possible to have *_xenstore = true and *_enhanced = false.
>>> I think it would be clearer if ``dom0less_enhanced`` is turned to an enum
>>> with 3 values:
>>> - None
>>> - NOXENSTORE/BASIC
>>> - FULLY_ENHANCED
>>>
>>> If we want to be future proof, I would use a field 'flags' where non-zero
>>> means enhanced. Each bit would indicate which features of Xen is exposed.
>> I think that could be a good solution if we do it this way:
>> - define a dom0less feature field and have defines like the following:
>> #define DOM0LESS_GNTTAB
>> #define DOM0LESS_EVENTCHN
>> #define DOM0LESS_XENSTORE >
>> - define dom0less enhanced as the right combination:
>> #define DOM0LESS_ENHANCED = (DOM0LESS_GNTTAB| DOM0LESS_EVENTCHN|
>> DOM0LESS_XENSTORE)
>
> I would rather introduce DOM0LESS_ENHANCED_BASIC (or similar) instead of
> defining a bit for gnttab and evtchn. This will avoid the question of why we
> are introducing bits for both features but not the hypercall...
>
> As this is an internal interface, it would be easier to modify afterwards.
How about this?
/*
* List of possible features for dom0less domUs
*
* DOM0LESS_ENHANCED_BASIC: Xen PV interfaces, including grant-table and
* evtchn, will be
enabled for the VM.
* DOM0LESS_XENSTORE: Xenstore will be enabled for the VM.
* DOM0LESS_ENHANCED: Xen PV interfaces, including grant-table
xenstore
* and evtchn, will be
enabled for the VM.
*/
#define DOM0LESS_ENHANCED_BASIC BIT(0, UL)
#define DOM0LESS_XENSTORE BIT(1, UL)
#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC | DOM0LESS_XENSTORE)
Regards,
Rahul
|
