[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Fri, 2 Sep 2022 15:02:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=L/DjP9kbZrH6f4cd2GhqVT/6jsLpXWi3yOm0TDoZ/c7vUaaqUp5zTUqpwBHf6fKzvjJcg6JW7xyNexSWax7RJCAPM6igZevR6aLRTsgvlIekC0ytVMVOVHWfSFpc8UalMEk8uVUv6wMLarHK1FGCqz9Zm0S6PHI2vQ+ajR/JxB2nJkXw282ZxTMfX3RLMQOLQigxd83+CG2lNaXhc4LgwntA3mNGtRYBDvvcncs0tRI6M0LaReuqB3jgeXcHcJ8r2wncybfwcj/cx7Cns0xGkRfr9INgNIYXf9BwVR0wjs4UjiiUeGD9hCJA/4ZJu4Z8L0OnRVLrlZu5XMP1mdDAuw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hfmu6RFcwy0jtroWdMtyZfHH9lJ5HBEtyduPA+q04kg=; b=FBZhdmYeLomx9M8UQL6HfxKz6xes3JdUFRr/T6g0usGVZKAXrO49jrt3sMaSE/Orn9ka6oXvafKG7fWaHwh7YKXA7x2ZJzMu5bKAOPZtrzbh7o8TMMs9INLoAasZde787GeBnToWx41sD+E1tdYIUf3Hf0HEP+F9i9yQiCuTxxTkrF/HMxOdWWD6O9oX5/FhC/teykvg5EQeKX+8wQPLJSnpJTvYl5+YWkCPCL3zpU1oHO1O/6KEpclmNweITwweUVs/p4uHbNUeUiK2sKjs5CKeUBswNKpavrjsWx/WE3sGAEK2wDmjshbEip19/IY6BQbK38YMz5r0B3V6/XCDAg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gOMCztR32DKUnLYx47/uVf1oViinWEKbZ2oeospcr3cD942GXHBLxj8XF0Spbon3yUlScTDmDjflnaXivz+ScVHBqR48tJKgpOL4X9fJ+UOmC3ROgxDo5DzOo0obAku/tNqIoEG5B9lo/Y4d7hAKdoGS6MfsEQqgGG6KoYz9IwXJYKmaPTzDb++Cdw7Tp1T0QeUdPrv5nAPNzTdVFtJYxNpUMtm3RhU0roAxAKI05GgN/Y8J1GsXqMbZQP+CuOhygGK5YpzDZ+u4Dej6ZIcXkoD+jJcox9j5iAi6EDrQsnrjjcgjiPiZ+GP75Jl0QZjF0/vkzY4Bs364DFMbFv2iag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVCnZv8B3zMxmZl3IinJAC+zGd5WbMtoO1PRn7mBmrQ5jrfI/2L+U+qLqFETfFSbgtrw0i3TWkh5LGS/R9jemLJQwTMMLGHLR6ZAykJLgqbDkFoIhRhpEuJuUdWrclxr5qrMreBbhjuebQaQcrAo9RXqVt4xIucjTdDARQ4R4oG6TckGLgSJZjwRrKJyghpKfol60pPow/UVhg4UAArnZ2maUsf1ziwi/7BIQlzEt8JO3CC9Fb3QDSbyK5muYj5H6iAhkOAheY+36GiVoiTniWPrVMktp0sDR1v052yhfXGg4WwVwHcvJ+ySlizR+/CcXn6vYx7mzlusB1XpiMZyWg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 02 Sep 2022 15:02:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFcTAA=
- Thread-topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value
Hi Julien,
> On 1 Sep 2022, at 7:15 pm, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Rahul,
>
> On 01/09/2022 10:13, Rahul Singh wrote:
>> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to
>> disable xenstore interface for dom0less guests.
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> ---
>> Changes in v3:
>> - new patch in this version
>> ---
>> docs/misc/arm/device-tree/booting.txt | 4 ++++
>> xen/arch/arm/domain_build.c | 10 +++++++---
>> xen/arch/arm/include/asm/kernel.h | 3 +++
>> 3 files changed, 14 insertions(+), 3 deletions(-)
>> diff --git a/docs/misc/arm/device-tree/booting.txt
>> b/docs/misc/arm/device-tree/booting.txt
>> index edef98e6d1..87f57f8889 100644
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -204,6 +204,10 @@ with the following properties:
>> - "disabled"
>> Xen PV interfaces are disabled.
>> + - no-xenstore
>> + Xen PV interfaces, including grant-table will be enabled for the VM but
>> + xenstore will be disabled for the VM.
>
> NIT: I would drop one of the "for the VM" as it seems to be redundant.
Ack.
>
>> +
>> If the xen,enhanced property is present with no value, it defaults
>> to "enabled". If the xen,enhanced property is not present, PV
>> interfaces are disabled.
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 4b24261825..8dd9984225 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -3336,10 +3336,14 @@ static int __init construct_domU(struct domain *d,
>> (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) )
>> {
>> if ( hardware_domain )
>> - kinfo.dom0less_enhanced = true;
>> + kinfo.dom0less_xenstore = true;
>> else
>> - panic("Tried to use xen,enhanced without dom0\n");
>> + panic("Tried to use xen,enhanced without dom0 without
>> no-xenstore\n");
>
> This is a bit hard to parse. How about:
>
> "At the moment, Xenstore support requires dom0 to be present"
Ack.
>
>> }
>> + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") )
>> + kinfo.dom0less_xenstore = false;
>> +
>> + kinfo.dom0less_enhanced = true;
>
> Wouldn't this now set dom0less_enhanced unconditionally?
Yes , I will fix this in next version.
Regards,
Rahul
|
