[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 2 Sep 2022 08:21:19 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=jA6snh7Kw4bO89kV+sjwjRvNGox9tQKlCb7zLZrmX3MzKV4mWF3SwY6zA/XDdyY2i901QXAHNJ5Bn+kMMk6CMhxrYYLAMjpcIH2TueJAqW1kV3O3yEICXhbOKdePVK5Qmb5ZQaiM8abbCP04APPkFLNysTASruH86vgjn2U8EHf0m3SJXAaWiQ5V7P3sk7SfujGGSEgoMcj65ea40/H/VlJ6Mm0qGq7ApsdteWgXuMMycE34cE3G/jiWGoK+xjd+nGGODKxABRqENGUQjqajUMC+u+AuXvWvK4IjK7ZKltR6Ri9pwYfZL9lAVxrJVZXaZMI6HDfeWg7CZz62CboQiQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74eaIOaZRNx4sj0K2zxmuD1i6ICSV9sstwT5zWN8xVA=; b=KokWjtneyp9JQm1FYJphVr3TX/3lhV8yZMRRJFFzmxt5m/Xnz0m/BZq/uITBTkPlUIop6Xo9Z7qkjRmIzvZJ7ajHtvnwHAYHh1UeAK+pf6M40dxP2qzh434OPPj4NmuTtN0h0j1g3ecMLPEBBWMOi4r3otbB+zlfLixstBd8gw4kor8NS98VZu/cGIwJRnDfxTo14uSAv6AIjVwZRh0qptgRUPNTvFGkHBbRqTxu8ZPv0ZKZjIDeVJUksAo62OEap5Wdspw8eDnSg6YTy6kh4jPhzurCwviqBFGalwMFe2jehCXcUW/Mu+Jqfxp2McUio9VIS5lYJKnx7GcWPFdDMA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DZayc0qLHfxYA1ojBh2N+nbVpOlrmK9kAY+4FgX2mCgoT8ypIguxhc2HE4EE2nkgrYeb7iYay45lxBxT88PE2NJzd69lcizvKN1HTlQaV/tXpoenW7Ez5h9/dxIZTuChj0+ej0Tz0YziLaE1Wp3N6u/RYw4kPD5iYxWOJRrx82Ei86UuC0AoHCbHJ/wwa68gvhPtD9Ea7WUKX9j8ixE0ROh1zzKj6cOp0RywHD9C2lm6gxMrzvVHZs1beNmyQh+2aD4XDoWYr2Ca47Lv2NFDHUC4573U0AbSi8EUTs/6WFQiSWfsEnmeVWrlcxF+cpZx60FLdzE1P+Qph8H/+stbqA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5Wz8vubfEF62PxhH2Ye0vwT5Hmrt0One6pprNPhG9zrb8RMQ3PPIoUPH2vXnRM3uReiDnibYnEk83hJr/bG0tCXydCs2VN6meDpkY20TohEDwpVuTDZHUY6MJvG23hJrO1vKQZ0YPIZwnYoqM91JiCYZommhKDgEwPbI4rt7fQXg0JdG2mAvxPM83EbHDXfE+6jH4A84nfaruqIULY3iGSwDpxzccjKqD1Ultpu/vYuFiEazCSFqWSn/oS8Bpd0CKA76BXhFvl0h1cHvzN+zwXXSXOkDkuirG7zkg7F7IJ8TF5b3l5HsEXzWw18lRKTvQ3W7vc0GtOTbR+V3x0YMQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Fri, 02 Sep 2022 08:21:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ueuuTQX+2f5E69518db+C55q3KsXoAgAC0jPCAAG9VAIAABQZQ
- Thread-topic: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
Hi Julien,
> -----Original Message-----
> Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
>
> Hi Henry,
>
> On 02/09/2022 02:28, Henry Wang wrote:
> >> This is technically a change in behavior for Xen (we would panic rather
> >> than continue). I am happy with the proposal. However, this doesn't seem
> >> to be explained in the commit message.
> >>
> >> That said, I think this should be split in a separate patch along with
> >> the ones below (including the prototype changes).
> >
> > According to Michal's comment, I've removed the return type and function
> > prototype change in my local v2. So this patch itself is fine. My question
> now
> > would be, do maintainers think this change of behavior with processing the
> > chosen node be helpful?
>
> Yes. I think it is saner to stop booting early rather than seen random
> behavior afterwards.
Cool, I will then add the patch to this series.
>
> > Do we prefer an instant panic or current behavior?
>
> I think we should leave that up to the caller. Today, this is a panic()
> but we may decide differently in the future.
Agreed.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
