[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 2 Sep 2022 08:18:42 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=a1yzChJ1nUHm28ux0tW1Wl2Ws65a64+kQkDs2xea22wtqYQfmmZUM2woXgugrHW+s+G81TVdTGU4dgdt+pb2ZC6XU+02jl1jvNRogLdBLfSiPONuz0feJKAi0HxQRMeRPaIC5osMGR7qrdw7q4+2aucxc++4VSEViZVVWt9j9bq0vIiXmexrj3b6RAw3qWBDakpjyLqJuLEqMvx+glMqfhacU/vgqYuMfERhy/U5KwQVe3QTLkZKImf+usrTwMu0esprUOX89jaajfHmsifBcK8qsXaA9sL9tsyFNGp7B6K4xafKtiUL6DGS8tzezIrbJtGN2z76PlcEWAv5C2w8/A==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUVHDdxEJym8NDyFqApVQbksD709+G831EmR+xDOp7Y=; b=eMOLAUdRxGt5clL/5Nt6G1qhCkq4QgrbJ5Pe+0nj9VTs4V4IGuWjwwT41QTffKFNMH+spMoJRsWPozkqNWXtucnsvWkxmkPOOrJO/WSbbX6wS4qGecoWtzZfdlXdmADm99pkC292JjpGqTxUsKNvWKKZ/APDwe7Q+TNNAyPVs8Xqg3rGziMIA75pzVs9VkGCA29LEKlRpblqftz3g2BfAjq30AJIGhHYr70o93gOfvwnMMe6Mk9XRATK0vn0VigaodHMB0uHw7tf3LpJH7x2h6yt0jbH0R9GItM5LCHmFOL/vDKdMxPx2SKUIvitX1iQHd6mSOE/1gPZ9gzVRHuGVw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FTcNEYJ/N70G5dmbMcUaftY0FEtNU+Np4YoHG1LR9J+kKrAN2WJ+fQGsarewCy32tuYn4+bNymFA0dIRBhElQg2XgCYxop8c9hF6IBIR6gpBUqhaQgMxxXPIrPsNeSkLqNqHGTZeSEH4j+7/RhudPrt7zbg9If8nV5eCHr50x9PT4XJ6/oiz2WKF+V7YfnMDTp47252dGBIhjPZx/GaDOBF8E1mXnCgxaPMW78ZmP3BaJqx7F4svbVTilnDiu3GXbJS7lxcSfTazYR6pP+UyieroTzfkrmDfKstRvtHyu0pZNApLm/heHZ7dasGXwdrc5ToXKzz40FaJUZHYU2XWiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z4ZZw4J1eD0exYqF2YpEB/UmN6aBeyFMw+37aepBIQt5e3pApP53g63CE+a4jWR1aJHTDEYxvVhtujH9drL7IafbjnByMDnzVZWhtnCEgaecYKgG5RoJeAOetbVhi465zXAeTVpnVAHSyNefnGqn9sg8MHWqIukKHwOJdhllq9lQO4pGjogc6Jwtf1VE+fCVP4LyQBWuOOGCfSdXPpQFb15EsbKYkjFMQX7zxuQCA8QPef8bDl65lgK/0N4FwTth19J+dxuHhSbl35LCUhFy6e2mEOdn6QSL19nXpY7Zv/EG42oO4EUzZjUm9gxRg97M1dJq7brMQEnmLVtkoZ6+WQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 02 Sep 2022 08:18:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q3KwCgAgAAG+VCAABfUgIAApokQgABStYCAAADsEA==
- Thread-topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> > Thanks for the clarification. I checked the code and found the xenheap_*
> > variables are:
> > xenheap_virt_start, xenheap_virt_end, xenheap_mfn_start,
> > xenheap_mfn_end, xenheap_base_pdx.
> >
> > For clarification, do we need to change all of them to directmap_*?
>
> Good question.
:))) Thanks for your patience!
>
> >
> > A pure renaming should be easy (and I guess also safe), but maybe I am
> > overthinking because arm32 also uses xenheap_virt_end,
> xenheap_mfn_start
> > and xenheap_mfn_end. These variables refer to the real xenheap, I am not
> > sure renaming these would reduce the readability for arm32.
>
> So on arm32, only the xenheap is direct mapped today. So I think it
> would be fine to switch the name to "directmap_*". For extra clarify we
> could add an alias for arm32 between "xenheap_*" and "directmap_*".
Sounds good to me, I think I will try to add a separate patch for purely
renaming all above-mentioned variables, then another patch for creating the
alias for arm32. Hope you would fine with this plan.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
