Re: [PATCH v2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion

[Julien Grall <julien@xxxxxxx>]

On 24/08/2022 13:44, Bertrand Marquis wrote:
> > On 24 Aug 2022, at 13:33, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >
> > While Arm64 does so uniformly, for Arm32 only strchr() currently handles
> > this properly. Add the necessary conversion also to strrchr(), memchr(),
> > and memset().
> >
> > As to the placement in memset(): Putting the new insn at the beginning
> > of the function is apparently deemed more "obvious". It could be placed
> > later, as the code reachable without ever making it to the "1" label
> > only ever does byte stores.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
It is now committed.

Cheers,

--
Julien Grall