[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
On 22.08.2022 04:58, Wei Chen wrote: > Current NUMA nodes number is a hardcode configuration. This > configuration is difficult for an administrator to change > unless changing the code. > > So in this patch, we introduce this new Kconfig option for > administrators to change NUMA nodes number conveniently. > Also considering that not all architectures support NUMA, > this Kconfig option only can be visible on NUMA enabled > architectures. Non-NUMA supported architectures can still > use 1 as MAX_NUMNODES. Especially the uses of "NUMA nodes number" make this read somewhat odd. If I was to re-write all of this, it would become something like: Currently the maximum number of NUMA nodes is a hardcoded value. This provides little flexibility unless changing the code. Introduce a new Kconfig option to change the maximum number of NUMA nodes conveniently. Also considering that not all architectures support NUMA, this Kconfig option is only visible on NUMA enabled architectures. Architectures not supporting NUMA still use 1 for MAX_NUMNODES. > As NODES_SHIFT is currently unused, we're taking this > opportunity to remove it. > > Signed-off-by: Wei Chen <wei.chen@xxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> Note that there's an alternative with less #ifdef-ary: config NR_NUMA_NODES int "Maximum number of NUMA nodes supported" if NUMA range 2 64 if NUMA default "1" if !NUMA default "64" But I can see reasons why one might deem it better for there to not be any CONFIG_NR_NUMA_NODES in the resulting .config when !NUMA. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |