[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/public: move XEN_ACPI_ in a new header
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 Aug 2022 11:55:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sorpqu1Nu9cBh6zKWGDFGrO6MrpfPV8fPiBj7r8wJAU=; b=KcSyuIN7h2P9hmrpwAz1l3fVy8IUO0CHffJNjPTsQXTGow6JMocz4iO+C89YSW82nuE9kWtRNZsDpiMV9f0YqjuZZslUMnYlo/U4srnAqkQy9nYDxq3egpvgE3wDL2sSY6TZWkx5IE62AMKMLl/3RGfd+QJm6brSTylCtSZT0xRnqLevKIalbmL7myMDhWzXZXM9MYPLzFP6qerfkSViDRgRgej5wx8K63Pve7uAMKsZl6cDyEsKFyv+4Yn6VfN2+uBYkkphUMvLXC4rPAIlE4lsVFXVRUEaZwSa65FJmNdu0a3NggPHBFlkdUSeNBg8FRIhZKtlco2uSqaBCJMchA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUSaBbDRE9clxi3ukGMVjwPxYhE4lxTMX6VklDIMx09WykrvsAjoOvfVBfaTB0VIHpIAgmCK6DNAQutb6kFC/jNoNFZA57TkcoZ8LWi0lWOu3G0p+Ejgp8nuAW5EVWbvqf4u1zHV+ysl4xSXTvygVx0EfxbLrC55DoGptdPvXB7An59wYlOa4v5PA/wbF+bP6lIGH33oDIBQj2hxQWYSWwAHvG1JGjt+WWKqr1tA3irViknrvtBS/rgSjSeFF4mn5wmMI63WA6RRUae6RmgrHQfmlbjHUqlAr16PjvUAcm8usplvqHGo9I1at1OCDysI24yB22cPY5Yq6QacZrKYyQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: henry.wang@xxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 25 Aug 2022 09:55:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.08.2022 11:48, Bertrand Marquis wrote:
> When Xen is compiled for x86 on an arm machine, libacpi build is failing
> due to a wrong include path:
> - arch-x86/xen.h includes xen.h
> - xen.h includes arch-arm.h (as __i386__ and __x86_64__ are not defined
> but arm ones are).
>
> To solve this issue move XEN_ACPI_ definitions in a new header
> guest-acpi.h that can be included cleanly by mk_dsdt.c.
> Inside this header, only protect the definitions using ifdef
> __XEN_TOOLS__ as the defines are not used anywhere in the hypervisor and
> are not expected to be.
>
> Previous users needing any of the XEN_ACPI_ definitions will now need to
> include arch-x86/guest-acpi.h instead of arch-x86/xen.h
>
> Fixes: d6ac8e22c7c5 ("acpi/x86: define ACPI IO registers for PVH guests")
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> For the release manager:
> - risk: very low, the definitions moved are only used in mk_dsdt and
> external users would just have to include the new header.
> - advantage: we can now compile xen for x86 on arm build machines
I'll give it a little for Henry to possibly release-ack this, but since
strictly speaking this is a bug fix, I think it could also go in without
(as long as not actually objected to, of course).
Jan
|
