[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] libacpi: Fix cross building x86 on arm
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 24 Aug 2022 09:37:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hU5+3H1iUxR1K9573tw0Lom9BwwPLdGPI/yST3cfnpY=; b=BRU6OM+IvgcYheHbI2c2yqph3e9QrRsOANP54lUZoUovBAW+PNk9PU7688tVvAdRegGTymxIdWy8Asm9TvJ5il1Px3LmJu5WD3fyQk2P1yoEUYPfTePRpv2+3UmO8rSrQBK739tUh4TIShL6zgrU8KbgGDIw8hdZ0NJxHylfdzQpMtg7HVj/z8slxPEbYvgZVY7r30kG0mQPEHZt0/B6apHX5Z+txh2xFk1LpjhzRmJSidES4rx+KJMC12PdJS916JyBi1D62xF2V/ylk/ouJFGcaigk1/gNaoHSnIXj8eu1RsDuKAOPW876VvrtzmFUCxGeBuKkc1c4zIOrwUstog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQpczegMfgAd0pwY/xBGX+Mb/a7mQATVnPYbe3svtbBqTOnUM62VvPrvx6P7pFDFg+TrSRB+tLfB93RY0uuUO+WjJpIxrywqb1raOXeAhA7cus9yszgBB9OEenRwbIAL03VLDGTZCrj4VgVWC4u/pu0+CnkTGxkhEKQFw9KRWBPZ05nm2eCGewzlAe7mCbhZBCll3xQ+pgzs9NjGi9sAUKw2lxByciB6SNa6mgAe8t4QBe/QKt9KYc7rJUW/vpwN5g2cxpfjw65Rf4kwhFlb8kzYGYryNV1cYLByoR2nV2bvJU8vkeB20iUSMKbGrtKkBi/x+7gRr6/x5ejJIobiPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 07:37:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.08.2022 17:56, Bertrand Marquis wrote:
>> On 23 Aug 2022, at 16:45, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 23.08.2022 17:09, Bertrand Marquis wrote:
>>> How about moving those to a xen-acpi.h header and include that one in xen.h
>>> ?
>>
>> In principle okay, if there wasn't the need for HVM_MAX_VCPUS. With a
>> suitable comment it may be okay to live there. I'd be curious what
>> others think.
>
> The problem with this already exists in the current status as this is defined
> in
> hvm_info_table.h which is never included from arch-x86/xen.h
You're referring to it being necessary to explicitly include both headers.
That's not what I'm referring to, though: The tool imo shouldn't include
hvm_info_table.h, and hence the HVM_MAX_VCPUS would need to move as well.
> Including hvm_info_table.h from xen-acpi.h could create include path issues.
Include path issues? Both are / would be public headers. But as said, I
don't think any new header introduced for the purpose at hand should
include _any_ other public header.
> But as those are used nowhere apart from mk_dsdt, I would probably skip the
> include of xen-acpi.h from xen.h.
Hmm, yes, that's reasonable I guess as far as XEN_ACPI_* go. Of course
HVM_MAX_VCPUS is a different matter.
> Any chance that those XEN_ACPI_ are needed by some external tools that
> could get broken by this modification ?
Requiring them to include another header is, I think, a tolerable form
of breakage, the more that such breakage isn't very likely anyway.
Jan
|
