[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 2/2] Arm32: tidy the memset() macro
Hi Jan, On 19/08/2022 09:02, Jan Beulich wrote: I read the last part as we want a re-sync of the code (we haven't done one in the past couple of years).On 19.08.2022 09:58, Julien Grall wrote:On 19/08/2022 08:50, Jan Beulich wrote:- add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove excess parentheses - rename local variables to not have leading underscores - apply Xen coding styleThis code has been taken from Linux. From you write above, I don't see any strong reason for us to modify it (even if it is small).At least the MISRA issues want addressing, I suppose. Plus I wasn't able to spot the macro in Linux anymore (nor __memzero()), so to me there seemed to be little point to consider keeping anything "in sync" here. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |