Re: [PATCH v2 1/3] Add SPDX to CODING_STYLE

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 18/08/2022 23:03, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> ---
>   CODING_STYLE | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 3386ee1d90..5faf274b3a 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often 
> implicitly (Linux
>   coding style is fairly common). In general you should copy the style
>   of the surrounding code. If you are unsure please ask.
>   
> +SPDX
> +----
> +
> +New files should start with a single-line SPDX comment to express the
> +license, e.g.:
> +
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +See LICENSES/ for a list of licenses and SPDX tags currently used.
> +
A user reading CODING_STYLE and CONTRIBUTING may think they need to also 
add the full license (see the section "COMMON COPYRIGHT NOTICES").
So as we are going to promote SPDX, we should update CONTRIBUTING to 
reflect that the full license should not be present copied.
Cheers,

--
Julien Grall