Re: [PATCH V3 0/6] Virtio toolstack support for I2C and GPIO on Arm

[Oleksandr <olekstysh@xxxxxxxxx>]

On 04.08.22 10:01, Viresh Kumar wrote:
> Hello,
Hello Viresh


> This patchset adds toolstack support for I2C and GPIO virtio devices. This is
> inspired from the work done by Oleksandr for the Disk device.
>
> This is developed as part of Linaro's Project Stratos, where we are working
> towards Hypervisor agnostic Rust based backend [1].
>
> This is based of origin/staging (commit 01ca29f0b17a ("sched: dom0_vcpus_pin
> should only affect dom0")) which already has Oleksandr's patches applied.
>
> V2->V3:
> - Rebased over latest tree and made changes according to changes in Oleksandr's
>    patches from sometime back.
Thanks, I have reviewed all patches that touch libxl_arm.c (##3-6)



> - Minor cleanups.
>
> V1->V2:
> - Patches 3/6 and 4/6 are new.
> - Patches 5/6 and 6/6 updated based on the above two patches.
> - Added link to the bindings for I2C and GPIO.
> - Rebased over latest master branch.
>
>
> Thanks.
>
> --
> Viresh
>
> [1] 
> https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i7/
>
> Viresh Kumar (6):
>    libxl: Add support for Virtio I2C device
>    libxl: Add support for Virtio GPIO device
>    libxl: arm: Create alloc_virtio_mmio_params()
>    libxl: arm: Split make_virtio_mmio_node()
>    libxl: Allocate MMIO params for I2c device and update DT
>    libxl: Allocate MMIO params for GPIO device and update DT
>
>   tools/golang/xenlight/helpers.gen.go      | 212 ++++++++++++++++++++
>   tools/golang/xenlight/types.gen.go        |  54 ++++++
>   tools/include/libxl.h                     |  64 ++++++
>   tools/include/libxl_utils.h               |   6 +
>   tools/libs/light/Makefile                 |   2 +
>   tools/libs/light/libxl_arm.c              | 138 +++++++++++--
>   tools/libs/light/libxl_create.c           |  26 +++
>   tools/libs/light/libxl_dm.c               |  34 +++-
>   tools/libs/light/libxl_gpio.c             | 226 ++++++++++++++++++++++
>   tools/libs/light/libxl_i2c.c              | 226 ++++++++++++++++++++++
>   tools/libs/light/libxl_internal.h         |   2 +
>   tools/libs/light/libxl_types.idl          |  48 +++++
>   tools/libs/light/libxl_types_internal.idl |   2 +
>   tools/ocaml/libs/xl/genwrap.py            |   2 +
>   tools/ocaml/libs/xl/xenlight_stubs.c      |   2 +
>   tools/xl/Makefile                         |   2 +-
>   tools/xl/xl.h                             |   6 +
>   tools/xl/xl_cmdtable.c                    |  30 +++
>   tools/xl/xl_gpio.c                        | 142 ++++++++++++++
>   tools/xl/xl_i2c.c                         | 142 ++++++++++++++
>   tools/xl/xl_parse.c                       | 160 +++++++++++++++
>   tools/xl/xl_parse.h                       |   2 +
>   tools/xl/xl_sxp.c                         |   4 +
>   23 files changed, 1509 insertions(+), 23 deletions(-)
>   create mode 100644 tools/libs/light/libxl_gpio.c
>   create mode 100644 tools/libs/light/libxl_i2c.c
>   create mode 100644 tools/xl/xl_gpio.c
>   create mode 100644 tools/xl/xl_i2c.c
--
Regards,

Oleksandr Tyshchenko