[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 3 Aug 2022 13:58:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9X58dBGrmsJDVuukOgpfhtgGk7sBVQMsUdtuJZftnQ=; b=C5j2O2EGmuDl60aA7aj0o+G+eWmR6ANfW0dh/HSjyimH2N1MoqN9ajGWbxRWrBy5Xeb30lWWAc2Tg8q8NeTGcG8DOsu0Em3+HICz7KDMNBP7EmnLkeH+BJpGjGBZzevtt0QMkO/GyWNjUJLXkh7yrJDgvGxBdd3QuZx0SuplwYwDUp8inIhkbNcwojylAeGztTP3xfNw9sP3apK2DNfn9UfdG2vFOpnvfbVQas0KnfcHVz2aidBaleFvh5jbEDzbL0SwE+P63Dp1Dw/iwAvvnURblG5GKV1dw8SKlB/BL/AwWFPQx3HJM75XE5EMhAicsqJOL+RaWbgoHj7FWhlj4w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iOt8YS0hUWBeIQGCiuP5/exRCUPUjIS1dSCzrGr97STCxEZTrq8DMUNL5CUT7cVesMDah7qCzq/LRMG8vRfy462PwpvMKaKeej2Bj1RBJZpZDYYMDzTxwRR+tV4UJr58JSA8cMkMVZxsCuxsXKJwF6U4jhaC/bAgUCn9khwpwg+yuQID7wiLcylQ/f34FEKJsOYsgjgLF3B4wTz4EYsYbIOCKmOurmS4fEWLqr3ZR7daP6qVNoSc9lwcR21sGgZV/J2tw9zrQ33IZvDD9p/vXzKS7VGAHsQ8ftRjYF3lq2VTSliy3ik9g+5TqsWwCQ5QX7+YAhh38X+j4kxOc03zow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 11:58:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.08.2022 12:57, Anthony PERARD wrote:
> On Wed, Aug 03, 2022 at 10:24:26AM +0000, Edwin Torok wrote:
>>
>> -ifneq ($(MAKECMDGOALS),clean)
>> +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
>
> I think it would be better with $(filter-out,):
>
> ifeq (,$(filter-out %clean,$(MAKECMDGOALS)))
>
>> .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile
>> $(OCAML_TOPLEVEL)/Makefile.rules
>> $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli
>> $o,MLDEP,)
>
> Also, don't hide this rule, instead, hide the "-include", there is no
> need to have make waist time trying to find a rule to make
> ".ocamldep.make" and failing when not needed.
Hmm, this sounds like I should be reverting the commit?
Jan
|
