[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 5/7] tools/ocaml: fix compiler warnings
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 3 Aug 2022 10:39:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENCSsqmbTySPdPn36dZWePkQkkPgtif6n/XSn8TRlLs=; b=VYkq4UlE7SZRt3bf6vgzBOil1KqTYxV30Ik7M3Jc01HsfBAfMx4QLITptargHRnJPMRjiryD6Bcimq/xr0WvBHB4HlZ/0W8EKEjDRxGxHLHQZKpr+rCHThzNHJjqkqactk0aVpZ552qdQMgrTz/qbP9fuMYx6cHEanRHjweOHyywFIi15ILPKxSwOrmXGEfA92WAQbW45mWhU0bXolZr5wOSELtAfiEqjxECTaeZHJnSR5fyOOir1Y/+4mn3AXAIsSsyuwYbJfT0euxIzoU2HXcwYKg/tb4GWOig78WWVq19PKvnPCDlF4JkZa4hrpnKSSLgxbtUiVhxctfDBH6hOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfSQDzQSrL+pEss+gWi2YU+hUznF3q3JdCZhQBWTmFclT0I6kFzo8dTMGjUPHLem8OWuQuNSM6xzBOYnvGVcINlhTfF2H79icZfoNqAXvJYmxygemXrmsYanYymiwkiT8+KQyHU7waL9l2KRUDa0JJyySFMtgjJdbw42w2iA0wjLaO/ntL/NIVrlW37aYa6YojD4LmOVRqOKyGkQs37mmu/1DY+OyBg8eG9KskWWi3ulYIUIpfZluXYud3nyX7EGs4l9EoGhbj+DIK5hemEWY3CbnX8L9XXi9jrCI5Y3jQupv0Aak0e0NtyFbUBBov+zmbmXrBvJDJOqq5WsIYpxhA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 10:39:19 +0000
- Ironport-data: A9a23:min5gKlp2/taIZgS+X+lQHro5gyeJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZUGDTOPfZZzGkf95/PIngoUgO7JPcnNVmHlFv/i5nEiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37Kyp4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2l1H9YC1sF0JF117 Ns1OBMpbD6vg9mPlefTpulE3qzPLeHNFaZH4DRb62icCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAH7g7PzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLarSz92LeWxEsXXqogPbmkxOE7g2ah6XY4LiwdU3KapfKQ3xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xCmEaQxZbZdchtctwQiYlv neWm/v5CDopt6eaIU9x7Z+RpDK2fDMTdGYEbCpcFw8duYG/+sc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm
- Ironport-hdrordr: A9a23:Wydi86iMskl4ZGYmzNF0ji9V+HBQX3l13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMlP8Pe
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYo3REcE7+4JA+40iNK344d92dpK2dA58A
- Thread-topic: [PATCH v1 5/7] tools/ocaml: fix compiler warnings
On 29/07/2022 18:53, Edwin Török wrote:
> diff --git a/tools/ocaml/xenstored/connection.ml
> b/tools/ocaml/xenstored/connection.ml
> index 65f99ea6f2..a94d47cdc2 100644
> --- a/tools/ocaml/xenstored/connection.ml
> +++ b/tools/ocaml/xenstored/connection.ml
> @@ -313,7 +313,7 @@ let is_bad con = match con.dom with None -> false | Some
> dom -> Domain.is_bad_do
> let has_extra_connection_data con =
> let has_in = has_input con || has_partial_input con in
> let has_out = has_output con in
> - let has_socket = con.dom = None in
> + let _has_socket = con.dom = None in
There are no side effects here. Can't the line simply be deleted?
~Andrew
|
