[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and...
Hi Jan, On 25/07/2022 16:51, Jan Beulich wrote: On 20.07.2022 20:44, Julien Grall wrote:From: Julien Grall <jgrall@xxxxxxxxxx> move it to Kconfig. The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide helpers to map/unmap a domain page. Rename it to the define to CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove support for domain page (this is not a concept that Xen can't get away with).Especially the part in parentheses reads odd, if not backwards. Indeed. I tweaked the sentence to:Rename it to CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that support for domain page is not something that can be disabled in Xen. --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -371,7 +371,7 @@ void clear_fixmap(unsigned int map) BUG_ON(res != 0); }-#ifdef CONFIG_DOMAIN_PAGE+#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE /* * Prepare the area that will be used to map domheap pages. They are * mapped in 2MB chunks, so we need to allocate the page-tables up toWhat about the other #ifdef in build_assertions()? With that also converted (and preferably with the description adjusted) Good catch. I update the patch. Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Thanks for the review! Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |