[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 28 Jul 2022 16:17:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mo7sOtI6KgCguR/fGcGZ2tlVZjkl9xKuor/v6/nyoG8=; b=DYYN7Gwpi4Jq/JoU3kdsImsBtmiMK2pRN0PYKRyjMt4hmghxukeOkOudLRz5KlA2m4pSZKvU5IjPjE2pQb+jhwO+piXCDOCW3Y/FNDa4232dadXkCO14Yl4EssRTyiRfZR2hnVt6G+xf9hGfACbat7dHSOnopvBfCB5H+hM9RuXq5NX0W2tjObVAJDQ5lmtKl6CzpRDFvCLNh7Nq33nXcVyHYyf5hHdH+g+ACetrT+eBPVyUFVv7lYim9cmTu1pGD+7OQEC9kG572q7E0HN3i8LIayZhi88GZMKTDob6F1G6GWL+yj99kPYfXJoivEBz1EbsQ9grv5VGfFg1nzOT2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ji8V2yJc/ERM5mHrxU0Xwr2ZgPyelgGxVWmyZqW+6QvlkPZmuRA7Tmy0ex7ahz8Gi5UZr6FS9IYhb2CxxOLOjR8LawbUDNqLRbAm4o75Sxs7vMXAT2Ahyg5w4PKyKUjwOQqfdguHBY+9fvEl9ahYuU+AHNJ4LArhgWcv+Rta3rxWNd0pfsmyNt5PAnFiN6c5PEIfOGibq/iiQH6fnDYPXL7gWHagpgXjneCJNizBzRPmrNNsXZIPqyuY1zYJrnodpgnx2iC/vwKeQA1nNhkKKOcAfWEa6L9fphbk8An2s+XS5h6U36g5aOVm0Rol5Z1tl+2XV2dNMTsvCXjB9J+iXw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 28 Jul 2022 14:17:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.07.2022 15:49, Xenia Ragiadakou wrote:
> --- a/xen/arch/arm/include/asm/arm64/sysregs.h
> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h
> @@ -461,7 +461,7 @@
> /* Access to system registers */
>
> #define WRITE_SYSREG64(v, name) do { \
> - uint64_t _r = v; \
> + uint64_t _r = (v); \
> asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \
Out of curiosity - why is the intermediate variable necessary?
Can't v be used directly in the asm(), possibly with a suitable
modifier added to %0 such that it'll always be x<N> (and not
w<N>) which is used as the operand to "msr"?
Jan
|
