[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view
- To: Oleksandr <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 28 Jul 2022 09:04:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eb3PDVQs7FlAqnRbsY4JVCnfJzt6AEgUfDJbtfulbcc=; b=AVJdVYLF1Bu8TWI2E4TixZkfiJnuGZstBKq3gp2BLoA87mQg2TpUtBNFR9tOjsU09OBWDjLsz0kV7zD+J0uWbvna1xUEFoRccoWunZb0pWajEzIWEkCYsfGdetCCKjRSXffDkM8Vax6Q7f93c3XZc5Jasg7SIj7bpGXpoGxVy7vbXO8Bbkdofamv9oRTkCGpPW/l8m7Z3dV/vrlLAKWsv8D+TMZHokzOKx1AYeVhlGDaPyf5OTuDEHV47x3MtuZdaF8nD5If3khZXWL1YuOpA8mhvqt8nv4L/iAvR0Wy0mDMPxJRCG60mrbdPhm0BhMG5m/qFkdG2U48MQXoPAtTdA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wi3DmqpSdUjCf1a/yGbwf95N+1btNCpv/o3qhbYKhidv5geMnP3kX+7Wd0JzuX3A0NHZ4T07k254EbZuQpcVL2L9+tbtIo9jdgUlo/9Xls9cBp4T7RME10o1zS4NxGGo8AR0VWN8+0qdxbPTBAYCOn6+m7qT9e+S8k3AGS+TJgxdTotOsdBkJz2oFsY9WcDYCzP1GCwetnatt9QkElqnnzv2y6e7LAWQL/KlECN4+bpv/Uka9vsR5CTfVFC0hHfjOe+RAlcrNJhocx0gpjDOSTOFPXGuHMir9574E34thc3ro/aJnN5k9+W6fPrFnXClPSzgLCwiyRtlK5JQYDF8bQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 28 Jul 2022 07:04:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.07.2022 19:06, Oleksandr wrote:
> On 27.07.22 13:19, Jan Beulich wrote:
>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>
>>> Take into account guest's BAR view and program its p2m accordingly:
>>> gfn is guest's view of the BAR and mfn is the physical BAR value as set
>>> up by the PCI bus driver in the hardware domain.
>>> This way hardware domain sees physical BAR values and guest sees
>>> emulated ones.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> If taking the previous patch as given, the patch here looks okay to me.
>
> This is a good news, thank you.
>
>
>> But since I'm still not really agreeing with what the previous patch
>> does,
>
> Previous? Sorry, I didn't see any comments given for "[PATCH V7 05/11]
> vpci/header: handle p2m range sets per BAR".
>
> Or do you perhaps mean "[PATCH V7 03/11] vpci/header: implement guest
> BAR register handlers" where you explicitly mentioned concerns?
No, I mean the previous patch, to which I had given comments in a much
earlier version. Roger looks to agree with the approach taken, so my
comments were (legitimately) put off. But with me not agreeing with
the approach, it's not very reasonable for me to (further) review that
change. Hence my deferral to Roger.
Jan
|
