[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/msr: fix X2APIC_LAST


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Wed, 27 Jul 2022 10:56:47 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jo4v3tCyTo7UsiCgD6FlMYvgg1umXOt+HzjEdqsAhXw=; b=Eyeiilu2TiJJqVKnytSICwx07g9hWP1Q2q0I6B3+/77t+lHrC9CSPSk8wfk/KxV7D+ucYPG1B2aOBr3vEWPe9rtmV5Vk6jrnwSKGT2JdkQ/gK7CFlU/qOONNtaDKxo1jrl6oxymMdTPi4lgakBxvbEGwllkRiUwnbWyZE+iCJfaRpSOHUMOWhDhT6RS9B8J9KN24SnODNSagUavlxDJMaz5vpqqDAibheHvfZ81o0KaJAEcbbMlPqsMFk7jJSgQin0IhlHMC9r6xee/faMa5Edd5IvZMfA1yuiLw67IUd5HaNA1kJrCv6SMdQe+tdeoh4xouOlGyaogA69jI+wbR8A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFsr+NfTVuS2k9nqtL5RE4vg4yaIcJX2aJbYKN054oRKX8/lDMJYARJ1JFTnEqMRW6Umi0aomC5W6yW7pREyWVknyg5ABGezLxFccf5ad8pmiQwf2QHjgy6x8xbxBmqtaN3IBHVK1A3y+MCg5R0Vphf6fayhmcNdG3qtoIBRzm8aaDdPk29EIIcHRUXwKrsbYT9bzCoe4e082SZb8lOi0M1nyjLuz3MAhtjL7VmZh97ZB78pgxeLRk1M1eK5h1bOFkXi3AriMztkJSAWYRlUMkNoyr9rxoO5eu25+yLAAB721Xg5e9ICUzs0S+SZjuZ8hMyIwYvxdyQQV04QC78HCw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
  • Delivery-date: Wed, 27 Jul 2022 10:57:09 +0000
  • Ironport-data: A9a23:9naJwqrZD3KlSPEzFWZ1bQemWABeBmLXZBIvgKrLsJaIsI4StFCzt garIBmBb/6KYDSkKo9zb4W0/EkBvMLXyIJrTAJu/i1mQnkVpZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVG0O17B2QVs sYTIXMANRuqhMWXwfGCH7wEasQLdKEHPas5k1Q5lXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NvuQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE2bGSx3qkAd16+LuQxtFDwwTM91IvCDoLbGun/um3lxKBYocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS6hyLjKzd4A+bB20NZj9HdNEi8sQxQFQC1 VKXntWvGT1mtpWUT26Q8vGfqjbaETcRBX8PY2kDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqY2O76T+FnGh3epucLPRwtsvgHPBDv9tEV+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRfHNKxzFF6afQL1t
  • Ironport-hdrordr: A9a23:3Vsgq6ypLVOgNCN8FOVnKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2x4Uh37D30XklZqvoJhiKobwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYoQRqcpYxNv8GZ0++T/cX45qn262Qx/AAgAACuoCAAAFdAIABQRAA
  • Thread-topic: [PATCH v2] x86/msr: fix X2APIC_LAST

On 26/07/2022 16:47, Jan Beulich wrote:
> On 26.07.2022 17:42, Andrew Cooper wrote:
>> On 26/07/2022 16:33, Jan Beulich wrote:
>>> On 26.07.2022 17:28, Edwin Török wrote:
>>>> The latest Intel manual now says the X2APIC reserved range is only
>>>> 0x800 to 0x8ff (NOT 0xbff).
>>>> This changed between SDM 68 (Nov 2018) and SDM 69 (Jan 2019).
>>>> The AMD manual documents 0x800-0x8ff too.
>>>>
>>>> There are non-X2APIC MSRs in the 0x900-0xbff range now:
>>>> e.g. 0x981 is IA32_TME_CAPABILITY, an architectural MSR.
>>>>
>>>> The new MSR in this range appears to have been introduced in Icelake,
>>>> so this commit should be backported to Xen versions supporting Icelake.
>>>>
>>>> Backport: 4.13+
>>> FAOD nevertheless it'll be applied only back to 4.15.
>> It shouldn't go back before 4.16, because otherwise we start exposing a
>> bunch of MSRs (including undocumented ones on Haswell/Broadwell) which
>> were previously disallowed.
> Hmm, I'm confused - how would the limiting of this range cause more
> MSRs to be exposed in 4.15?

My mistake.  I forgot when we changed the MSR default readability.

This should go back to 4.15.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.