[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Jul 2022 18:06:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qiM5Ep+GIGxc9iGqIuErdW/YkbCSwfcFyzej4dHa1nU=; b=gSmfItKeTbY2YEHkO2k0nanqGRuZ5jY6XIN15HakqnhJaqPbCEMb/+H+J63/Zt6PO5j0oWH3mXp9/3sXfiWNBe6EG1vOnwfWas6cKA7JwqnwniBhxGhObV3YDPEnNfLn45PtAf97mnG+dFpWCOhodePfwfaejYS/jQ68w8MbAedR100J7MuNvX91yh7tdHUAfYCFz+Y+APSzq2SCJt2LGu+6RjLEy2nFk2HPI9KYRgYTr/Zn4aHlJBrQAB9C/iMqvMVyRIJGIB4bhEdLkyknv8KQ6xlINvs3y4LRAiPPDn9PGRUg6aE8mb4yx/ZgTwBziCIWxkpKimASFe9xBJ4wZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IhNPEsT0LgljoV7L82WarQM96DOb/sgRxWn4swUtd3UEXavXmfBgj61v0wq4R8Vd1s0HOXhqTIwL5/+8My5MqlhWaEcV/GzwS79jDlPjdwtdmldlPko40YhFhBuBJ/GC+w5uooDsJLqMC5F9iFDeUt2fFWyGMzK9BjpDdX76SJjje9LaGh3wf9mxreaD2HLYpnCQCuHlDLbIk0RsndX+XXOSvYO2obV1Y1EThyC+aEkLQp4ApBkELVqsR96awgTO2o0OdQqsiPAkN4Ea8E8tToO0P3LX74uYdjo3IIDveE1u1rXsfjoMWtVBvF+X+CcW56HNneNeMISXCrfGBnVpCw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Tue, 26 Jul 2022 16:06:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is
cleared upon de-validation (see also the respective assertion earlier in
the function).
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -3020,7 +3020,7 @@ static int _get_page_type(struct page_in
if ( d && shadow_mode_enabled(d) )
shadow_prepare_page_type_change(d, page);
- if ( (x & PGT_type_mask) != type )
+ if ( (x ^ type) & PGT_type_mask )
{
/*
* On type change we check to flush stale TLB entries. It is
|
