[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/8] mm: enforce return value checking on get_page()
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Jul 2022 18:04:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wpdBYL7DGs8sd5XkLM9xP2jAqMKLzNp/KEuELZbnd8A=; b=GhQy2IGPiYtRfhJNQrv+kNx+Uo55l0MoyFtmmw9aBlzLqDNQVNEIrGB4lpsfRV+NMZOVQitWofIyVDNoMQjDQzv2Z9evjzljvyTS/pYV6M0lgTjFDI/E/7Kmw/YHXyppge+qiHKQEV5xz4Ep/lR0Ctfd2DAXijzrAabz6+1zrnD4BYIW4kfGXExVulT5JteDI9KuXr7CRV2OEZHYwS0SVzMS4mSA3o6J0dvou7ywtRzPThgl9ZNMqq0ae2Svbpx2hOmUW2ikCpR9FJGe+41SDsQeNr4aJ03r1bQ8cfSIIF6Hu6oUPsG72Fk01HsMtZG6wih+eX1wipPAXNq7sHFDbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Emh5IvoUsjG/La8T6T1iozSiR/dDOjnEO4hxifz5fnilXmNZgZCQkM0/FyxgA0oGoiAei9ib26eS3rmJpn8lJQeym4Ebutp4BOfRps8KFKkh23USjbk/au7CJLSlc6ToeD8u8XimOtHRSTQ9iqeLu22VQS5ILK4kV6ZrXyn5n5zyQacG75yux6/a3BLd6dykXVTDhtlLKvbMrz9YCvmIUUXKb8SP3OCx2GJlXf/myz+iFTdAvH4bsJM7q2EB193WZFAcE8ganldHK+NTE5LiujkELnfZS4YYf4/ILEbx/vatd9CbIx75NkbVAJoCwbhMJ3955QtL6LAMRslJjGGFsQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 26 Jul 2022 16:04:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
It's hard to imagine a case where an error may legitimately be ignored
here. It's bad enough that in at least one case (set_shadow_status())
the return value was checked only by way of ASSERT()ing.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -61,7 +61,7 @@
struct page_info;
void put_page(struct page_info *);
-bool get_page(struct page_info *, const struct domain *);
+bool __must_check get_page(struct page_info *, const struct domain *);
struct domain *__must_check page_get_owner_and_reference(struct page_info *);
/* Boot-time allocator. Turns into generic allocator after bootstrap. */
|
