[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Smith, Jackson" <rsmith@xxxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 25 Jul 2022 17:44:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5aLSY46HCACeRx9OPpUpXthhlP/QIwvUeLDK/Y4t5AU=; b=hggJKQDcsKrGLyYog9uT1NhAisUS86bi0lHzvoprjekY9bIvS9/vivcx99hk5/wbuIJi0J8p2eRvfossLtvE7oJ4uJVOwUsH5A0suM+RiGJOW2c8LrpbJrPhqhhZkpTzM4vX8DvCeZK6WueGX37kd+qblhdLtgajKburlnFOyRXmWy2DxcRaLdsDP4RjkMO4Gfy3qa4XegMP64QMSKPFg/vb5b6tkYIYZoPzahg9lIbgGirlJLfqihsOXhK64djiKYiYtbd+xNWcfiXaKgNiShGv+WUkh2mXt0TXBYp9rUi/ePKgygZa9zAPni7Q5eB3ZGiAiRAicF/CT5o+vm7qcA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=UZXjv/69WcoUo1UfBHz0/bVuLuy7VLzpjf3ZiuywJD2rlLGJVVppPp5Ne3mE4KiV9IpyAZ4jzQHRB8+Fw8RcYNr+znnxDdMPy6/Wnusu7KzCm5+Q3CyI8LPqIyjtrT1VwHpa9IYQb/10I7zulEdIC9nE4eTLHC4nv/MF6pNzYlOKvFJRqq1c9cIcJu9qL8sLeS9dU0M9hCsxUGiV4QXrJXBnyNEjZTNCCYC7dk1v6M/aDbIw01aKT2MxyINRzcPIlJPVd9ZbgmmUDveBF1eRwEc+zzTka3gmcYUQvUyEnMRphfeN+m253ywHHgZa2Hg71mo2H1ZAA5dZmnmtOyaVuw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 25 Jul 2022 17:44:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AdigP3XkakTWEwukTeurpU94cGpQzA==
- Thread-topic: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
Hi Stefano,
My colleague Jason Lei and I would like to submit a patch to imagebuilder.
It seems that generating a .fit with a true dom0less configuration fails
because an extraneous comma is included in the its file.
We believe this change resolves the issue.
Thanks,
Jackson
-- >8 --
Remove extraneous comma in generated its file when no DOM0_KERNEL is specified.
diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index 8f08cd6..6f94fce 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -676,7 +676,12 @@ create_its_file_xen()
i=$(( $i + 1 ))
continue
fi
- load_files+=", \"domU${i}_kernel\""
+ if test -z "$load_files"
+ then
+ load_files+="\"domU${i}_kernel\""
+ else
+ load_files+=", \"domU${i}_kernel\""
+ fi
cat >> "$its_file" <<- EOF
domU${i}_kernel {
description = "domU${i} kernel binary";
|